From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Clifford Wolf <clifford@clifford.at>
Cc: kosaki.motohiro@jp.fujitsu.com, lkml <linux-kernel@vger.kernel.org>
Subject: Re: rlim in proc/<pid>/status
Date: Tue, 15 Jan 2008 19:47:22 +0900 [thread overview]
Message-ID: <20080115194321.119D.KOSAKI.MOTOHIRO@jp.fujitsu.com> (raw)
In-Reply-To: <20080115100631.GA13394@clifford.at>
Hi
sound good for me.
a few question please.
> + for (i=0; i<RLIM_NLIMITS; i++) {
> + if (rlim_names[i])
> + buffer += sprintf(buffer, "Rlim%s:\t", rlim_names[i]);
> + else
> + buffer += sprintf(buffer, "Rlim%d:\t", i);
this else is really necessary?
> + if (rlim[i].rlim_cur != ~0)
> + buffer += sprintf(buffer, "%lu\t", rlim[i].rlim_cur);
> + else
> + buffer += sprintf(buffer, "-\t");
> + if (rlim[i].rlim_max != ~0)
> + buffer += sprintf(buffer, "%lu\n", rlim[i].rlim_max);
> + else
> + buffer += sprintf(buffer, "-\n");
Why do you don't use RLIM_INFINITY?
- kosaki
next prev parent reply other threads:[~2008-01-15 10:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-15 10:06 [PATCH] " Clifford Wolf
2008-01-15 10:47 ` KOSAKI Motohiro [this message]
2008-01-15 12:15 ` Clifford Wolf
2008-01-15 20:36 ` [PATCH] " serge
2008-01-16 7:03 ` [PATCH] rlim in proc/<pid>/status (2nd rev.) Clifford Wolf
2008-01-16 7:33 ` KOSAKI Motohiro
2008-01-16 10:04 ` Clifford Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080115194321.119D.KOSAKI.MOTOHIRO@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=clifford@clifford.at \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®