mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michael Opdenacker <michael-lists@free-electrons.com>
To: linux-kernel@vger.kernel.org, mingo@redhat.com, hpa@zytor.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] x86: clean arch/[i386|x86_64] in make mrproper
Date: Thu, 17 Jan 2008 14:37:23 +0100	[thread overview]
Message-ID: <200801171437.25038.michael-lists@free-electrons.com> (raw)

Applies to: 2.6.24-rc8-git1

For backward compatibility with earlier (< 2.6.24) kernels,
arch/i386/boot/bzImage or arch/x86_64/boot/bzImage
symbolic links to arch/x86/boot/bzImage
are created when you build an x86 kernel.
The arch/i386 or arch/x86_64 directories are then
created for this only purpose.

Issue: these generated directories and symbolic
links are *not cleaned up* when you run
"make mrproper" (and thus "make distclean").
This disturbs the production of patches,
because the source tree is left with generated files
and directories.

Proposed fix: add arch/i386 and arch/x86_84 to
the list of directories cleaned by "make mrproper"

Cleaner solution: stop creating these symbolic
links, but this could cause issues with scripts
still expecting bzImage in arch/i386/boot/bzImage
or in arch/x86_64/boot/bzImage.

What do you think? I can submit another patch for
the second option.

Michael.

Signed-off-by: Michael Opdenacker <michael@free-electrons.com>
--- linux-2.6.24-rc8-git1/Makefile	2008-01-17 09:54:22.000000000 +0100
+++ linux-2.6.24-rc8-git1-mrproper-x86/Makefile	2008-01-17 10:49:19.000000000 +0100
@@ -1088,7 +1088,7 @@
                 .tmp_kallsyms* .tmp_version .tmp_vmlinux* .tmp_System.map
 
 # Directories & files removed with 'make mrproper'
-MRPROPER_DIRS  += include/config include2 usr/include
+MRPROPER_DIRS  += include/config include2 usr/include arch/i386 arch/x86_64
 MRPROPER_FILES += .config .config.old include/asm .version .old_version \
                   include/linux/autoconf.h include/linux/version.h      \
                   include/linux/utsrelease.h                            \


-- 
Michael Opdenacker, Free Electrons
Free Embedded Linux Training Materials
on http://free-electrons.com/training
(More than 1500 pages!)

             reply	other threads:[~2008-01-17 13:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-17 13:37 Michael Opdenacker [this message]
2008-01-18  8:10 ` Michael Opdenacker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200801171437.25038.michael-lists@free-electrons.com \
    --to=michael-lists@free-electrons.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome