mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Roland Dreier <rdreier@cisco.com>
Cc: kosaki.motohiro@jp.fujitsu.com,
	"Pravin Nanaware" <p.nanaware@nihilent.com>,
	"John Hubbard" <john.hubbard@gmail.com>,
	"LKML" <linux-kernel@vger.kernel.org>
Subject: Re: Bitops source problem
Date: Thu, 17 Jan 2008 15:59:24 +0900	[thread overview]
Message-ID: <20080117155723.11DC.KOSAKI.MOTOHIRO@jp.fujitsu.com> (raw)
In-Reply-To: <adamyr5x86k.fsf@cisco.com>

Hi

> If that is indeed the source of your change_bit function then there is
> a problem.  However in my kernel tree there is a LOCK_PREFIX in the
> definition of the atomic version.  I don't have your exact source tree
> handy, but on a local RHEL4 system, the LOCK_PREFIX is still there:
> 
> static inline void change_bit(int nr, volatile unsigned long * addr)
> {
>         __asm__ __volatile__( LOCK_PREFIX
>                 "btcl %1,%0"
>                 :"=m" (ADDR)
>                 :"Ir" (nr));
> }

2.6.24-rc6-mm1 have LOCK_PREFIX too :)


static inline void change_bit(int nr, volatile void *addr)
{
        asm volatile(LOCK_PREFIX "btc %1,%0"
                     : ADDR : "Ir" (nr));
}


  reply	other threads:[~2008-01-17  6:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-17  6:38 Pravin Nanaware
2008-01-17  6:44 ` Roland Dreier
2008-01-17  6:59   ` KOSAKI Motohiro [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-01-18  4:40 Pravin Nanaware
2008-01-17  8:11 Pravin Nanaware
2008-01-17 19:32 ` Roland Dreier
2008-01-17  5:09 Pravin Nanaware
2008-01-17  5:47 ` John Hubbard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080117155723.11DC.KOSAKI.MOTOHIRO@jp.fujitsu.com \
    --to=kosaki.motohiro@jp.fujitsu.com \
    --cc=john.hubbard@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=p.nanaware@nihilent.com \
    --cc=rdreier@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®