From: David Miller <davem@davemloft.net>
To: Robert.Olsson@data.slu.se
Cc: elendil@planet.nl, jesse.brandeburg@intel.com,
slavon@bigtelecom.ru, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [REGRESSION] 2.6.24-rc7: e1000: Detected Tx Unit Hang
Date: Fri, 18 Jan 2008 05:37:12 -0800 (PST) [thread overview]
Message-ID: <20080118.053712.195382841.davem@davemloft.net> (raw)
In-Reply-To: <18320.41737.651384.808195@robur.slu.se>
From: Robert Olsson <Robert.Olsson@data.slu.se>
Date: Fri, 18 Jan 2008 14:00:57 +0100
> I don't understand the idea with semaphore for enabling/disabling
> irq's either the overall logic must safer/better without it.
They must have had code paths where they didn't know if IRQs were
enabled or not already, so they tried to create something which
approximates the:
local_irq_save(flags);
local_irq_restore(flags);
constructs we have for CPU interrupts, so they could go:
e1000_irq_disable();
/* ... */
e1000_irq_enable();
and this would work even if the caller was running
with e1000 interrupts disabled already.
Or, something like that... it is indeed confusing.
Anyways, yes it's totally bogus and should be removed.
next prev parent reply other threads:[~2008-01-18 13:37 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-15 5:25 Frans Pop
2008-01-15 5:53 ` David Miller
2008-01-15 6:17 ` Frans Pop
2008-01-15 14:04 ` Frans Pop
2008-01-15 16:04 ` slavon
2008-01-15 21:53 ` Brandeburg, Jesse
2008-01-16 5:02 ` David Miller
2008-01-16 8:56 ` Frans Pop
2008-01-16 10:29 ` David Miller
2008-01-16 17:07 ` Robert Olsson
2008-01-18 12:11 ` David Miller
2008-01-18 13:00 ` Robert Olsson
2008-01-18 13:37 ` David Miller [this message]
2008-01-20 9:20 ` Brandeburg, Jesse
2008-01-20 9:28 ` Andrey Rahmatullin
2008-01-21 13:27 ` Robert Olsson
2008-01-21 13:29 ` David Miller
2008-01-17 7:09 ` Brandeburg, Jesse
2008-01-17 7:20 ` David Miller
2008-01-17 7:51 ` Frans Pop
2008-01-17 8:00 ` David Miller
2008-01-17 9:40 ` Arnaldo Carvalho de Melo
2008-01-17 9:45 ` David Miller
2008-01-16 9:02 ` Badalian Vyacheslav
2008-01-16 12:25 ` David Miller
2008-01-16 12:28 ` David Miller
2008-01-21 6:54 ` Badalian Vyacheslav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080118.053712.195382841.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Robert.Olsson@data.slu.se \
--cc=elendil@planet.nl \
--cc=jesse.brandeburg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=slavon@bigtelecom.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome