From: Roland McGrath <roland@redhat.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>,
tglx@linutronix.de, hpa@zytor.com, linux-kernel@vger.kernel.org
Subject: Re: x86: kdump failure
Date: Fri, 18 Jan 2008 16:01:19 -0800 (PST) [thread overview]
Message-ID: <20080119000119.3524B26F9FD@magilla.localdomain> (raw)
In-Reply-To: Ingo Molnar's message of Friday, 18 January 2008 10:02:05 +0100 <20080118090205.GA24337@elte.hu>
Oops, I overlooked the use of elf_core_copy_regs in kernel/kexec.c. It
is certainly safe and fine to reintroduce the old macro. Everything
removed in the "x86 user_regset cleanup" patch is purely removing code
and it doesn't hurt to have it back (it's just all unused except for this
kexec nit).
Unfortunately it really doesn't fit to have kexec call into the new
user_regset code that replaced this macro for user core dump purposes.
Those new interfaces are really purely for user-mode state, derived only
from task_struct (i.e. uses task_pt_regs), not from a struct pt_regs
pointer passed in. (There is the minority case where it really is using
user-mode state. That part could be done via the user_regset interface,
if that saved any trouble.)
Things like crash_fixup_ss_esp point to the poor fit of the code intended
for user core dumps with what kexec needs. IMHO it would be cleaner for
kexec's arch interfaces to fill in elf_gregset_t directly, replacing some
of the places a struct pt_regs is passed around now.
crash_setup_regs already has to know the name of every register anyway.
A particular arch's definition can share code with its core dump or
user_regset code when that fits.
Thanks,
Roland
prev parent reply other threads:[~2008-01-19 0:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-14 19:04 [PATCH] x86_32: remove warning message not used Hiroshi Shimamoto
2008-01-14 19:09 ` Ingo Molnar
2008-01-14 19:19 ` Hiroshi Shimamoto
2008-01-15 2:03 ` [PATCH] x86: move warning message of polling idle and HT enabled Hiroshi Shimamoto
2008-01-15 13:26 ` Ingo Molnar
2008-01-15 17:53 ` Hiroshi Shimamoto
2008-01-15 18:56 ` [PATCH 0/2] x86: move warning message of polling idle and HT enabled, take 3 Hiroshi Shimamoto
2008-01-15 18:59 ` [PATCH 1/2] x86: move warning message of polling idle and HT enabled Hiroshi Shimamoto
2008-01-18 12:56 ` Ingo Molnar
2008-01-15 19:01 ` [PATCH 2/2] x86_64: move select_idle_routine() call after detect_ht() Hiroshi Shimamoto
2008-01-18 12:56 ` Ingo Molnar
2008-01-18 2:52 ` x86: kdump failure Hiroshi Shimamoto
2008-01-18 9:02 ` Ingo Molnar
2008-01-18 9:29 ` Subrata Modak
2008-01-19 0:01 ` Roland McGrath [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080119000119.3524B26F9FD@magilla.localdomain \
--to=roland@redhat.com \
--cc=h-shimamoto@ct.jp.nec.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®