From: Greg KH <greg@kroah.com>
To: Jan Beulich <jbeulich@novell.com>
Cc: linux-kernel@vger.kernel.org, davem@davemloft.net,
schwidefsky@de.ibm.com, mingo@elte.hu, tony.luck@intel.com,
paulus@samba.org, gregkh@suse.de
Subject: Re: [PATCH 1/3] constify struct attribute_group uses
Date: Fri, 18 Jan 2008 17:26:36 -0800 [thread overview]
Message-ID: <20080119012636.GA6150@kroah.com> (raw)
In-Reply-To: <478738F3.76E4.0078.0@novell.com>
On Fri, Jan 11, 2008 at 08:37:55AM +0000, Jan Beulich wrote:
> .. as all consumers of it don't require it to be modifiable.
>
> Unfortunately, due to the two-level constifications, this required
> touching quite many files, not all of which I am able to test - please
> bare with eventual mistakes or oversights.
>
> The patch doesn't change all instances where 'const' could have been
> added as a result of the base structure changes, only where either the
> change has a real effect (the module loader doesn't enforce read-only
> section attributes at present, so only built-in files matter) or where
> compiler warnings would result otherwise.
Hm, code in these areas has changed a lot in -mm, can you respin this
against that tree to catch all of the different attribute changes that
has happened?
thanks,
greg k-h
prev parent reply other threads:[~2008-01-19 1:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-11 8:37 Jan Beulich
2008-01-19 1:26 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080119012636.GA6150@kroah.com \
--to=greg@kroah.com \
--cc=davem@davemloft.net \
--cc=gregkh@suse.de \
--cc=jbeulich@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=schwidefsky@de.ibm.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome