From: Sam Ravnborg <sam@ravnborg.org>
To: Jeremy Fitzhardinge <jeremy@xensource.com>,
Chris Wright <chrisw@sous-sol.org>
Cc: "Toralf Förster" <toralf.foerster@gmx.de>,
linux-kernel@vger.kernel.org, rusty@rustcorp.com.au,
"WANG Cong" <xiyou.wangcong@gmail.com>
Subject: [PATCH] xen: fix section usage in xen-head.S
Date: Sat, 19 Jan 2008 14:17:43 +0100 [thread overview]
Message-ID: <20080119131743.GA26615@uranus.ravnborg.org> (raw)
In-Reply-To: <20080118161452.GJ2559@hacking>
Failing to specify "ax" in the pushsection caused ld to generate
an additional section for .init.text appending a number.
A side effect of this was a section mismatch warning because modpost
did not recognize a .init.text section named .init.text.1:
WARNING: vmlinux.o(.text.head+0x247): Section mismatch: reference to .init.text.1:start_kernel (between 'is386' and 'check_x87')
Fix this by hardcoding the "ax" in the pushsection.
Thanks to Torlaf for reporting this.
Alan Modra @ binutils provided the hint that made me
able to locate the root cause of this warning.
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Jeremy Fitzhardinge <jeremy@xensource.com>
Cc: Chris Wright <chrisw@sous-sol.org>
Cc: WANG Cong <xiyou.wangcong@gmail.com>
Cc: Toralf Förster <toralf.foerster@gmx.de>
---
diff --git a/arch/x86/xen/xen-head.S b/arch/x86/xen/xen-head.S
index f8d6937..b05e85d 100644
--- a/arch/x86/xen/xen-head.S
+++ b/arch/x86/xen/xen-head.S
@@ -7,7 +7,7 @@
#include <asm/boot.h>
#include <xen/interface/elfnote.h>
-.pushsection .init.text
+.pushsection .init.text, "ax"
ENTRY(startup_xen)
movl %esi,xen_start_info
cld
next prev parent reply other threads:[~2008-01-19 13:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-18 12:18 build #343 issue for v2.6.24-rc8-29-g03bbe08 : Section mismatch: reference to .init.text.1:start_kernel (between 'is386' and 'check_x87') Toralf Förster
2008-01-18 12:29 ` WANG Cong
2008-01-18 12:46 ` Sam Ravnborg
2008-01-18 12:51 ` WANG Cong
2008-01-18 13:22 ` Sam Ravnborg
2008-01-18 16:14 ` WANG Cong
2008-01-18 18:47 ` Sam Ravnborg
2008-01-19 11:20 ` WANG Cong
2008-01-18 19:03 ` [PATCH for -rc] kbuild: fix false section mismatch warning referring to .init.text.2 Sam Ravnborg
2008-01-19 13:17 ` Sam Ravnborg [this message]
2008-01-19 21:20 ` [updated PATCH] xen: fix section usage in xen-head.S and setup.c Sam Ravnborg
2008-01-19 22:23 ` Jeremy Fitzhardinge
2008-01-19 22:43 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080119131743.GA26615@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=chrisw@sous-sol.org \
--cc=jeremy@xensource.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=toralf.foerster@gmx.de \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome