From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Tejun Heo <htejun@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Georgi Chulkov <g.chulkov@jacobs-university.de>,
linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
Mark Lord <liml@rtr.ca>
Subject: Re: ATA device reset, shoud I be concerned?
Date: Mon, 21 Jan 2008 16:47:44 +0000 [thread overview]
Message-ID: <20080121164744.2f7d0ed1@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <4794ACAF.70505@gmail.com>
> Can you elaborate a bit? I don't really think completing a command
> after 30sec timeout contributes a lot to driver stability.
Timeout, timeout, timeout, reset, timeout.. (repeat), failed I/O
This gives the end user no information about the fault, nor does it let
the upper layers of SCSI and above distinguish between a random passing
sulk and media errors which need the disk replacing.
> > Should that not then be a per host flag ?
>
> Yeah, that would be the best. The problem is that there are several
> different kinds of timeouts and we don't know which controller locks up
> after which timeout and investigating them is really difficult.
PATA controllers don't lock up in that case so its quite easy. The one
exception is if the device jams IORDY but in that case you are dead
anyway the next I/O (except on a SIL680 which has a timer we could use).
Old IDE says it works for PATA. For SATA I can see it might need more
care and you might simply not be able to get the info.
Alan
next prev parent reply other threads:[~2008-01-21 16:50 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-13 22:19 Georgi Chulkov
2008-01-15 10:54 ` Andrew Morton
2008-01-15 11:35 ` Alan Cox
2008-01-21 7:56 ` Tejun Heo
2008-01-21 13:02 ` Alan Cox
2008-01-21 13:14 ` Tejun Heo
2008-01-21 14:14 ` Alan Cox
2008-01-21 14:31 ` Tejun Heo
2008-01-21 14:33 ` Tejun Heo
2008-01-21 16:44 ` Alan Cox
2009-08-27 2:40 ` Robert Hancock
2009-08-27 3:07 ` Jeff Garzik
2009-08-27 8:37 ` Alan Cox
2008-01-21 16:47 ` Alan Cox [this message]
2008-01-21 17:02 ` Tejun Heo
2008-01-21 17:27 ` Alan Cox
2008-01-22 0:31 ` Tejun Heo
2008-01-22 1:31 ` Bartlomiej Zolnierkiewicz
2008-01-22 1:36 ` Tejun Heo
2008-01-22 2:08 ` Tejun Heo
2008-01-22 1:39 ` Alan Cox
2008-01-22 20:29 ` Georgi Chulkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080121164744.2f7d0ed1@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@linux-foundation.org \
--cc=g.chulkov@jacobs-university.de \
--cc=htejun@gmail.com \
--cc=liml@rtr.ca \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®