From: Marc Pignat <marc.pignat@hevs.ch>
To: Haavard Skinnemoen <hskinnemoen@atmel.com>
Cc: Andrew Victor <linux@maxim.org.za>,
kernel@avr32linux.org, linux-kernel@vger.kernel.org,
Remy Bohmer <linux@bohmer.net>,
Chip Coldwell <coldwell@redhat.com>
Subject: Re: [PATCH 6/6] atmel_serial: Add DMA support
Date: Tue, 22 Jan 2008 17:52:43 +0100 [thread overview]
Message-ID: <200801221752.43830.marc.pignat@hevs.ch> (raw)
In-Reply-To: <1201013444-30370-7-git-send-email-hskinnemoen@atmel.com>
Hi!
I removed linux-arm-kernel@lists.arm.linux.org.uk from cc, it is a
subscriber-only list.
On Tuesday 22 January 2008, Haavard Skinnemoen wrote:
> From: Chip Coldwell <coldwell@redhat.com>
...
> @@ -47,6 +50,11 @@
>
> #include "atmel_serial.h"
>
> +#define SUPPORT_PDC
> +#define PDC_BUFFER_SIZE (L1_CACHE_BYTES << 3)
> +#warning "Revisit"
why add this warning?
...
> @@ -1090,7 +1434,7 @@ static int atmel_serial_suspend(struct platform_device *pdev,
> struct atmel_uart_port *atmel_port = (struct atmel_uart_port *)port;
>
> if (device_may_wakeup(&pdev->dev)
> - && !at91_suspend_entering_slow_clock())
> + && !clk_must_disable(atmel_port->clk))
1. this has nothing to do with dma
2. clk_must_disable isn't in mainline (2.6.24-rc8) for at91 (not verified for avr32).
CONFIG_MAGIC_SYSRQ isn't working with this pach, (CONFIG_MAGIC_SYSRQ has never
worked with atmel_serial dma patches).
For me breaking CONFIG_MAGIC_SYSRQ is not a critical regression and can be
fixed later, but the "clk_must_disable" problem breaks compilation.
Regards
Marc
next prev parent reply other threads:[~2008-01-22 16:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-22 14:50 [PATCH v3 0/6] atmel_serial: Cleanups, irq handler splitup & DMA Haavard Skinnemoen
2008-01-22 14:50 ` [PATCH 1/6] atmel_serial: Clean up the code Haavard Skinnemoen
2008-01-22 14:50 ` [PATCH 2/6] atmel_serial: Use cpu_relax() when busy-waiting Haavard Skinnemoen
2008-01-22 14:50 ` [PATCH 3/6] atmel_serial: Use existing console options only if BRG is running Haavard Skinnemoen
2008-01-22 14:50 ` [PATCH 4/6] atmel_serial: Fix bugs in probe() error path and remove() Haavard Skinnemoen
2008-01-22 14:50 ` [PATCH 5/6] atmel_serial: Split the interrupt handler Haavard Skinnemoen
2008-01-22 14:50 ` [PATCH 6/6] atmel_serial: Add DMA support Haavard Skinnemoen
2008-01-22 16:52 ` Marc Pignat [this message]
2008-01-23 11:53 ` Haavard Skinnemoen
2008-01-23 12:30 ` Marc Pignat
2008-01-23 12:45 ` Haavard Skinnemoen
2008-01-23 13:18 ` Marc Pignat
2008-01-23 13:35 ` Haavard Skinnemoen
2008-01-23 13:52 ` Marc Pignat
2008-01-23 14:05 ` Haavard Skinnemoen
2008-01-23 15:04 ` Alan Cox
2008-01-23 15:14 ` Haavard Skinnemoen
2008-01-23 16:41 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801221752.43830.marc.pignat@hevs.ch \
--to=marc.pignat@hevs.ch \
--cc=coldwell@redhat.com \
--cc=hskinnemoen@atmel.com \
--cc=kernel@avr32linux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@bohmer.net \
--cc=linux@maxim.org.za \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®