From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755636AbYAWHaB (ORCPT ); Wed, 23 Jan 2008 02:30:01 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753379AbYAWH3y (ORCPT ); Wed, 23 Jan 2008 02:29:54 -0500 Received: from pasmtpb.tele.dk ([80.160.77.98]:60860 "EHLO pasmtpB.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752646AbYAWH3x (ORCPT ); Wed, 23 Jan 2008 02:29:53 -0500 Date: Wed, 23 Jan 2008 08:30:01 +0100 From: Sam Ravnborg To: Randy Dunlap Cc: lkml , perex@perex.cz, akpm Subject: Re: [PATCH] sound: fix opti9xx/miro section mismatch Message-ID: <20080123073001.GC19132@uranus.ravnborg.org> References: <20080122213947.f044c040.randy.dunlap@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080122213947.f044c040.randy.dunlap@oracle.com> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 22, 2008 at 09:39:47PM -0800, Randy Dunlap wrote: > From: Randy Dunlap > > snd_opti93x_mixer() is only called by __devinit snd_opti93x_probe(), > so the former can also be __devinit. > > snd_miro_mixer() is only called by __devinit snd_miro_probe(), > so the former can also be __devinit. > > sound/isa/opti9xx/opti92x-ad1848.c: > WARNING: vmlinux.o(.text+0xf91cd7): Section mismatch: reference to .init.data:snd_opti93x_controls (between 'snd_opti93x_mixer' and 'snd_card_opti9xx_free') > WARNING: vmlinux.o(.text+0xf91d66): Section mismatch: reference to .init.data:snd_miro_controls (between 'snd_opti93x_mixer' and 'snd_card_opti9xx_free') > > opti9xx/miro.c: > WARNING: vmlinux.o(.text+0xf926c2): Section mismatch: reference to .init.data:snd_miro_controls (between 'snd_miro_mixer' and 'snd_legacy_find_free_ioport') > WARNING: vmlinux.o(.text+0xf926e5): Section mismatch: reference to .init.data:snd_miro_eq_controls (between 'snd_miro_mixer' and 'snd_legacy_find_free_ioport') > WARNING: vmlinux.o(.text+0xf926f9): Section mismatch: reference to .init.data:snd_miro_line_control (between 'snd_miro_mixer' and 'snd_legacy_find_free_ioport') > WARNING: vmlinux.o(.text+0xf92716): Section mismatch: reference to .init.data:snd_miro_amp_control (between 'snd_miro_mixer' and 'snd_legacy_find_free_ioport') > WARNING: vmlinux.o(.text+0xf9273e): Section mismatch: reference to .init.data:snd_miro_preamp_control (between 'snd_miro_mixer' and 'snd_legacy_find_free_ioport') > WARNING: vmlinux.o(.text+0xf92764): Section mismatch: reference to .init.data:snd_miro_capture_control (between 'snd_miro_mixer' and 'snd_legacy_find_free_ioport') > WARNING: vmlinux.o(.text+0xf92783): Section mismatch: reference to .init.data:snd_miro_radio_control (between 'snd_miro_mixer' and 'snd_legacy_find_free_ioport') > WARNING: vmlinux.o(.text+0xf9279a): Section mismatch: reference to .init.data:snd_miro_eq_controls (between 'snd_miro_mixer' and 'snd_legacy_find_free_ioport') > WARNING: vmlinux.o(.text+0xf927b9): Section mismatch: reference to .init.data:snd_miro_radio_control (between 'snd_miro_mixer' and 'snd_legacy_find_free_ioport') > > Signed-off-by: Randy Dunlap Acked-by: Sam Ravnborg > --- > sound/isa/opti9xx/miro.c | 2 +- > sound/isa/opti9xx/opti92x-ad1848.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > --- linux-2.6.24-rc8-git5.orig/sound/isa/opti9xx/miro.c > +++ linux-2.6.24-rc8-git5/sound/isa/opti9xx/miro.c > @@ -662,7 +662,7 @@ static int __devinit snd_set_aci_init_va > return 0; > } > > -static int snd_miro_mixer(struct snd_miro *miro) > +static int __devinit snd_miro_mixer(struct snd_miro *miro) > { > struct snd_card *card; > unsigned int idx; > --- linux-2.6.24-rc8-git5.orig/sound/isa/opti9xx/opti92x-ad1848.c > +++ linux-2.6.24-rc8-git5/sound/isa/opti9xx/opti92x-ad1848.c > @@ -1595,7 +1595,7 @@ OPTi93X_DOUBLE("Capture Volume", 0, OPTi > } > }; > > -static int snd_opti93x_mixer(struct snd_opti93x *chip) > +static int __devinit snd_opti93x_mixer(struct snd_opti93x *chip) > { > struct snd_card *card; > struct snd_kcontrol_new knew; > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/