mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Ian Abbott <abbotti@mev.co.uk>
Cc: linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz,
	pcihpd-discuss@lists.sourceforge.net, gregkh@suse.de,
	kristen.c.accardi@intel.com
Subject: Re: [RESEND][PATCH-2.6.24-rc8] Fix fakephp deadlock
Date: Wed, 23 Jan 2008 09:46:39 -0800	[thread overview]
Message-ID: <20080123174639.GB10387@kroah.com> (raw)
In-Reply-To: <4795FD78.6020208@mev.co.uk>

On Tue, Jan 22, 2008 at 02:28:08PM +0000, Ian Abbott wrote:
> #include <linux/init.h>
> #include <linux/string.h>
> #include <linux/slab.h>
> +#include <linux/workqueue.h>
> #include "../pci.h"
> #if !defined(MODULE)
> @@ -63,10 +64,13 @@ struct dummy_slot {
> 	struct list_head node;
> 	struct hotplug_slot *slot;
> 	struct pci_dev *dev;
> +	struct work_struct remove_work;
> +	unsigned long removed;

You are treating "removed" as an atomic value, so why not just make it
an atomic_t?

And what is protecting the fact that the flag could be set right after
it gets checked?  I don't see a lock here :)

thanks,

greg k-h

  reply	other threads:[~2008-01-23 17:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-22 14:28 Ian Abbott
2008-01-23 17:46 ` Greg KH [this message]
2008-01-23 18:38   ` Ian Abbott
2008-01-23 18:42     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080123174639.GB10387@kroah.com \
    --to=greg@kroah.com \
    --cc=abbotti@mev.co.uk \
    --cc=gregkh@suse.de \
    --cc=kristen.c.accardi@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    --cc=pcihpd-discuss@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®