mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Haavard Skinnemoen <hskinnemoen@atmel.com>
Cc: bn@niasdigital.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm] fix variable use in AVR32 pte_alloc_one
Date: Wed, 23 Jan 2008 23:55:31 -0800	[thread overview]
Message-ID: <20080123235531.9334c13a.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080123132010.266eccb8@dhcp-252-066.norway.atmel.com>

> On Wed, 23 Jan 2008 13:20:10 +0100 Haavard Skinnemoen <hskinnemoen@atmel.com> wrote:
> On Wed, 23 Jan 2008 22:57:34 +1100
> Ben Nizette <bn@niasdigital.com> wrote:
> 
> > 
> > Some parts of this function use 'page', some 'pte'.  As such, an AVR32
> > -mm build fails with an undefined reference to 'page'.
> > 
> > Signed-Off-By: Ben Nizette <bn@niasdigital.com>
> > 
> > ---
> > Index: linux-2.6.24-rc8-mm1/include/asm-avr32/pgalloc.h
> > ===================================================================
> > --- linux-2.6.24-rc8-mm1.orig/include/asm-avr32/pgalloc.h
> > +++ linux-2.6.24-rc8-mm1/include/asm-avr32/pgalloc.h
> > @@ -52,9 +52,9 @@ static inline struct page *pte_alloc_one
> >  	struct page *pte;
> >  
> >  	pte = alloc_page(GFP_KERNEL | __GFP_REPEAT | __GFP_ZERO);
> > -	if (!page)
> > +	if (!pte)
> >  		return NULL;
> > -	pgtable_page_ctor(page);
> > +	pgtable_page_ctor(pte);
> >  	return pte;
> >  }
> 
> Hmm...I can't see anything like this on my current avr32-arch branch,
> but I think I mistakenly pushed out some unfinished code about a week
> ago and rewound it shortly afterwards. If Andrew pulled during that
> window, I guess it must have made it into -mm :-(
> 
> But thanks for testing and for providing a fix. I'll check the code
> that I was working on and apply the patch if it's still broken.
> 

This bustage was added by the -mm-only
config_highpte-vs-sub-page-page-tables.patch

Thanks for the fix.

      parent reply	other threads:[~2008-01-24  7:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-23 11:57 Ben Nizette
2008-01-23 12:20 ` Haavard Skinnemoen
2008-01-23 23:32   ` Ben Nizette
2008-01-24 12:01     ` [PATCH -mm] Fix timerfd breakage on avr32 (was Re: [PATCH -mm] fix variable use in AVR32 pte_alloc_one) Haavard Skinnemoen
2008-01-24  7:55   ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080123235531.9334c13a.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=bn@niasdigital.com \
    --cc=hskinnemoen@atmel.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome