mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Ingo Molnar <mingo@elte.hu>,
	linux-kernel@vger.kernel.org,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Linux Crypto Mailing List <linux-crypto@vger.kernel.org>
Subject: Re: [build bug] ./drivers/crypto/hifn_795x.c
Date: Sat, 26 Jan 2008 13:43:43 +0300	[thread overview]
Message-ID: <20080126104342.GB26275@2ka.mipt.ru> (raw)
In-Reply-To: <20080125224545.GA1757@gondor.apana.org.au>

Hi.

On Sat, Jan 26, 2008 at 09:45:45AM +1100, Herbert Xu (herbert@gondor.apana.org.au) wrote:
> On Fri, Jan 25, 2008 at 11:21:50PM +0100, Ingo Molnar wrote:
> > 
> > randconfig testing found this (post-v2.6.24) build bug:
> > 
> >  drivers/built-in.o: In function `hifn_unregister_rng':
> >  hifn_795x.c:(.text+0x17bbd9): undefined reference to `hwrng_unregister'
> >  drivers/built-in.o: In function `hifn_probe':
> >  hifn_795x.c:(.text+0x17df70): undefined reference to `hwrng_register'
> > 
> > config attached.
> 
> Thanks for the report.  This is casued by
> 
> > CONFIG_HW_RANDOM=m
> > CONFIG_CRYPTO_DEV_HIFN_795X=y
> 
> I'll fix it with the following patch.

Thanks for fixing that up, if people who do not like select will
complain, we can make hifn rng depend on hw_random.

-- 
	Evgeniy Polyakov

  reply	other threads:[~2008-01-26 10:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-25 22:21 Ingo Molnar
2008-01-25 22:45 ` Herbert Xu
2008-01-26 10:43   ` Evgeniy Polyakov [this message]
2008-01-25 23:51 ` Ingo Molnar
2008-01-25 23:53   ` Herbert Xu
2008-01-25 23:59     ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080126104342.GB26275@2ka.mipt.ru \
    --to=johnpol@2ka.mipt.ru \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®