From: David Miller <davem@davemloft.net>
To: jmorris@namei.org
Cc: herbert@gondor.apana.org.au, torvalds@linux-foundation.org,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [AUDIT]: Increase skb->truesize in audit_expand
Date: Mon, 28 Jan 2008 20:47:29 -0800 (PST) [thread overview]
Message-ID: <20080128.204729.194426943.davem@davemloft.net> (raw)
In-Reply-To: <Xine.LNX.4.64.0801290112300.12951@us.intercode.com.au>
From: James Morris <jmorris@namei.org>
Date: Tue, 29 Jan 2008 01:13:03 +1100 (EST)
> On Mon, 28 Jan 2008, Herbert Xu wrote:
>
> > Hi:
> >
> > [AUDIT]: Increase skb->truesize in audit_expand
> >
> > The recent UDP patch exposed this bug in the audit code. It
> > was calling pskb_expand_head without increasing skb->truesize.
> > The caller of pskb_expand_head needs to do so because that function
> > is designed to be called in places where truesize is already fixed
> > and therefore it doesn't update its value.
> >
> > Because the audit system is using it in a place where the truesize
> > has not yet been fixed, it needs to update its value manually.
> >
> > Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
>
> Acked-by: James Morris <jmorris@namei.org>
>
>
> (Candidate for stable ?)
Applied, and yes I'll queue this up for -stable.
prev parent reply other threads:[~2008-01-29 4:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-28 11:10 Herbert Xu
2008-01-28 14:13 ` James Morris
2008-01-29 4:47 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080128.204729.194426943.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome