From: Borislav Petkov <petkovbb@gmail.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH 0/32] ide-tape redux v1
Date: Mon, 28 Jan 2008 06:43:43 +0100 [thread overview]
Message-ID: <20080128054343.GB3074@gollum.tnic> (raw)
In-Reply-To: <200801272045.40712.bzolnier@gmail.com>
Hi Bart,
[...]
> > the BKL in idetape_write_release() with finer-grained locking etc, probably also
> > some pipeline improvements, removal of OnStream support, etc. but that'll come
> > later.
>
> On-Stream support has been long gone but it seems that deprecation
> warning etc. managed to survive.
>
> w.r.t. to the pipeline-mode: it should be pipelined into /dev/null
>
> rationale:
> - it is _very_ complex
> - causes errors to be deferred till the next user-space access
> - direct I/O using blk_rq_map_user() will offer superior performance
>
> the only question is whether to remove it...
Well, on the one hand, since the driver is only being maintained we should not
remove code that works. Also, i don't know how many users ide-tape really has
but, would it be worth the trouble at all? Because if nobody's using it, we
could just as well pipe the whole thing into /dev/null.. On the other hand, the
pipelining part _is_ kinda big and, right, it is not that straightfoward to
look at it and know what it actually does - it truly is a student project :)
> > Documentation/ide/ChangeLog.ide-tape.1995-2002 | 405 +++
> > drivers/ide/Kconfig | 3 +-
> > drivers/ide/ide-tape.c | 4146 +++++++++---------------
> > 3 files changed, 1991 insertions(+), 2563 deletions(-)
[...]
> BTW what happend to patch #23?
Well, it appeared in my lkml mailbox having gone over vger which means at least
somebody got it :). But, yeah, that was a real nightmare yesterday sending all
those patches in one go. See, i got a stupid umts modem behind a not so transparent
proxy :) whose subnet is listed in almost every spam database on the planet
and whenever i try to send more than one mail i hit all sorts of mail server
restrictions like yahoo's maximum messages per day crap.. Gmail seems a bit
smarter ?! and scans the mail message and then says all kinds of funny stuff :):
27 10:48:31 gollum postfix/smtp[4011]: F1710123BFD: to=<linux-ide@vger.kernel.org>, relay=vger.kernel.org[209.132.176.167]:25,
delay=10, delays=0.19/0.29/2.7/7.2, dsn=2.7.1, status=sent (250 2.7.1 Looks like Linux source DIFF email.. BF:<H 1.55041e-06>; S1753942AbYA0Js4)
what's next, probably something like:
...(250 3.x.x uh, ok, i'm gonna relay your mail but please have another coffee, please) <hash>;
Anyway, resending #23 to you in a private mail.
--
Regards/Gruß,
Boris.
next prev parent reply other threads:[~2008-01-29 4:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-27 8:41 Borislav Petkov
2008-01-27 8:41 ` [PATCH 1/32] ide-tape: move historical changelog to Documentation/ide/ChangeLog.ide-tape.1995-2002 Borislav Petkov
2008-01-27 15:18 ` Bartlomiej Zolnierkiewicz
2008-01-27 8:41 ` [PATCH 2/32] ide-tape: remove dead code Borislav Petkov
2008-01-27 8:41 ` [PATCH 3/32] ide-tape: remove struct idetape_request_sense_result_t Borislav Petkov
2008-01-27 15:19 ` Bartlomiej Zolnierkiewicz
2008-01-27 8:41 ` [PATCH 4/32] ide-tape: remove struct idetape_mode_parameter_header_t Borislav Petkov
2008-01-27 15:25 ` Bartlomiej Zolnierkiewicz
2008-01-27 8:41 ` [PATCH 5/32] ide-tape: remove IDETAPE_DEBUG_INFO Borislav Petkov
2008-01-27 19:45 ` [PATCH 0/32] ide-tape redux v1 Bartlomiej Zolnierkiewicz
2008-01-28 5:43 ` Borislav Petkov [this message]
2008-01-30 0:29 ` Bartlomiej Zolnierkiewicz
2008-02-01 8:21 ` Borislav Petkov
2008-01-28 15:54 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080128054343.GB3074@gollum.tnic \
--to=petkovbb@gmail.com \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®