mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Ingo Molnar <mingo@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] x86: fix usage of .section .sched.text in assembler code
Date: Mon, 28 Jan 2008 11:13:34 +0100	[thread overview]
Message-ID: <20080128101333.GB24010@elte.hu> (raw)
In-Reply-To: <20080126225306.GA27215@uranus.ravnborg.org>


* Sam Ravnborg <sam@ravnborg.org> wrote:

> Without this patch the linker will generate a section named 
> .sched.text.1 which is unexpected. This is because the gcc generated 
> section has "ax" but the assembler usage of .sched.text lacks the "ax" 
> specifier.

thanks, applied.

> It would be better to have a definition we could use from assembler 
> code but I did not find a suitable header file for it.

hm, include/asm-x86/linkage.h?

btw., i guess this in include/linux/linkage.h:

#ifndef __ALIGN
#define __ALIGN         .align 4,0x90
#define __ALIGN_STR     ".align 4,0x90"
#endif

is an x86-ism (0x90 is the x86 NOP instruction) that should move into 
include/asm-x86/linkge.h and the default filler should be 0x00 instead?

	Ingo

  reply	other threads:[~2008-01-28 10:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-26 22:53 Sam Ravnborg
2008-01-28 10:13 ` Ingo Molnar [this message]
2008-01-28 18:52   ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080128101333.GB24010@elte.hu \
    --to=mingo@elte.hu \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=sam@ravnborg.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome