From: David Miller <davem@davemloft.net>
To: den@openvz.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devel@openvz.org
Subject: Re: [PATCH 1/6] [IPV4]: Fix memory leak on error path during FIB initialization.
Date: Thu, 31 Jan 2008 05:14:44 -0800 (PST) [thread overview]
Message-ID: <20080131.051444.157479191.davem@davemloft.net> (raw)
In-Reply-To: <1201780850-22216-1-git-send-email-den@openvz.org>
From: "Denis V. Lunev" <den@openvz.org>
Date: Thu, 31 Jan 2008 15:00:45 +0300
> commit c8050bf6d84785a7edd2e81591e8f833231477e8
> Author: Denis V. Lunev <den@openvz.org>
> Date: Thu Jan 10 03:28:24 2008 -0800
I am fixing it up for you this time, but please do not
reference the commit this way.
Say something like:
blah blah blah in commit $(SHA1_HASH) ("commit head line").
The author and date give no real useful information in
this context, the important part is giving the reader
enough information to find the commit should they wish
to gain more information.
If they have the commit hash they can usually find the
commit, but if that fails they can search the commit
messages for the head line text string.
I feel like I've had to explain this 10 times in the past week...
:-/
next prev parent reply other threads:[~2008-01-31 13:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <47A1B835.7050600@sw.ru>
2008-01-31 12:00 ` Denis V. Lunev
2008-01-31 13:14 ` David Miller [this message]
2008-01-31 12:00 ` [PATCH 2/6] [IPV4]: Small style cleanup of the error path in rtm_to_ifaddr Denis V. Lunev
2008-01-31 12:00 ` [PATCH 3/6] [NETNS]: Process interface address manipulation routines in the namespace Denis V. Lunev
2008-01-31 12:00 ` [PATCH 4/6] [IPV4]: fib_sync_down rework Denis V. Lunev
2008-01-31 12:00 ` [PATCH 5/6] [NETNS]: Add a namespace mark to fib_info Denis V. Lunev
2008-01-31 12:00 ` [PATCH 6/6] [NETNS]: Lookup in FIB semantic hashes taking into account the namespace Denis V. Lunev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080131.051444.157479191.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=den@openvz.org \
--cc=devel@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®