From: Arjan van de Ven <arjan@infradead.org>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Sam Ravnborg <sam@ravnborg.org>, Adrian Bunk <bunk@kernel.org>,
davem@davemloft.net, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
"Maciej W. Rozycki" <macro@linux-mips.org>
Subject: Re: [PATCH] kill hotplug init/exit section annotations
Date: Thu, 31 Jan 2008 08:11:20 -0800 [thread overview]
Message-ID: <20080131081120.27505dc0@laptopd505.fenrus.org> (raw)
In-Reply-To: <1201795051.3131.13.camel@localhost.localdomain>
On Thu, 31 Jan 2008 09:57:31 -0600
James Bottomley <James.Bottomley@HansenPartnership.com> wrote:
> No-one seems to see much value in these, and they cause about 90% of
> our problems with __init/__exit markers, so simply eliminate them.
> Rather than run over the whole tree removing them, this patch
> #defines them to be nops.
>
> Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
>
> ---
>
> I'll probably be going after __exit after this one, but it makes sense
> to split them up, since the hotplug annotation removal looks
> uncontroversial, whereas __exit and discard section removal might
> produce more robust debate. I also think doing the hotplug removal
> gives us 90% of the benefits and removes 90% of the section mismatch
> problems.
Since hotplug is so fundamental nowadays the value no longer outweighs the pain/cost
to me, so
Acked-by: Arjan van de Ven <arjan@linux.intel.com>
--
If you want to reach me at my work email, use arjan@linux.intel.com
For development, discussion and tips for power savings,
visit http://www.lesswatts.org
next prev parent reply other threads:[~2008-01-31 16:11 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-30 20:03 [2.6 patch] scsi/qlogicpti.c section fixes Adrian Bunk
2008-01-30 21:00 ` James Bottomley
2008-01-30 21:20 ` Sam Ravnborg
2008-01-30 21:30 ` Adrian Bunk
2008-01-30 21:41 ` James Bottomley
2008-01-30 22:00 ` Sam Ravnborg
2008-01-30 22:32 ` Value of __*{init,exit} anotations? Adrian Bunk
2008-01-30 22:44 ` James Bottomley
2008-01-30 22:50 ` Russell King
2008-01-31 5:42 ` Andi Kleen
2008-01-31 7:44 ` Sam Ravnborg
2008-01-31 15:57 ` [PATCH] kill hotplug init/exit section annotations James Bottomley
2008-01-31 16:11 ` Arjan van de Ven [this message]
2008-01-31 16:21 ` Adrian Bunk
2008-01-31 17:07 ` Arjan van de Ven
2008-01-31 17:14 ` Adrian Bunk
2008-01-31 17:45 ` Chris Wedgwood
2008-01-31 17:55 ` Adrian Bunk
2008-01-31 18:32 ` Chris Wedgwood
2008-01-31 18:52 ` Geert Uytterhoeven
2008-01-31 17:48 ` Arjan van de Ven
2008-01-31 18:34 ` Sam Ravnborg
2008-01-31 18:48 ` Arjan van de Ven
2008-01-31 19:41 ` Sam Ravnborg
2008-01-30 22:28 ` [2.6 patch] scsi/qlogicpti.c section fixes Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080131081120.27505dc0@laptopd505.fenrus.org \
--to=arjan@infradead.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=bunk@kernel.org \
--cc=davem@davemloft.net \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=macro@linux-mips.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®