Re: [PATCH -mm v4 6/9] atmel_serial: Split the interrupt handler

[Haavard Skinnemoen <hskinnemoen@atmel.com>]

On Thu, 31 Jan 2008 02:53:50 +0100
michael <trimarchi@gandalf.sssup.it> wrote:

> The overrun still remain. An lrz receive session is impossible using
> full preemption. I will try the dma patch too and test in iso mode for 
> smart card.

Hmm. Seems to work reasonably well on a non-rt kernel -- I get quite a
few overruns, but nothing more than the Zmodem protocol can handle.

It seems to be very sensitive to network traffic though...could it have
something to do with softirq scheduling? Could you try the patch below
and see if you can trigger the error message?

Haavard

diff --git a/drivers/serial/atmel_serial.c b/drivers/serial/atmel_serial.c
index 477950f..c61fcc3 100644
--- a/drivers/serial/atmel_serial.c
+++ b/drivers/serial/atmel_serial.c
@@ -337,9 +337,12 @@ atmel_buffer_rx_char(struct uart_port *port, unsigned int status,
 	struct circ_buf *ring = &atmel_port->rx_ring;
 	struct atmel_uart_char *c;
 
-	if (!CIRC_SPACE(ring->head, ring->tail, ATMEL_SERIAL_RINGSIZE))
+	if (!CIRC_SPACE(ring->head, ring->tail, ATMEL_SERIAL_RINGSIZE)) {
+		dev_err(port->dev, "RX ring buffer full, dropping data\n");
+
 		/* Buffer overflow, ignore char */
 		return;
+	}
 
 	c = &((struct atmel_uart_char *)ring->buf)[ring->head];
 	c->status	= status;