From: Andi Kleen <ak@suse.de>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Andi Kleen <ak@suse.de>, mingo@elte.hu, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [7/9] Add an option to disable direct mapping gbpages and a global variable
Date: Thu, 31 Jan 2008 17:24:00 +0100 [thread overview]
Message-ID: <20080131162400.GB25989@bingen.suse.de> (raw)
In-Reply-To: <alpine.LFD.1.00.0801311711130.9204@apollo.tec.linutronix.de>
On Thu, Jan 31, 2008 at 05:12:35PM +0100, Thomas Gleixner wrote:
> On Tue, 29 Jan 2008, Andi Kleen wrote:
> > +int direct_gbpages;
> > +
> > +static int __init parse_direct_gbpages(char *arg)
> > +{
> > + if (!strcmp(arg, "off")) {
> > + direct_gbpages = -1;
> > + return 0;
> > + }
> > + return -1;
> > +}
> > +early_param("direct_gbpages", parse_direct_gbpages);
>
> Can we please use simple boolean logic ? This 0, -1, 1 magic is more
> than confusing.
I did it this way to later allow forcing gbpages. This actually
makes sense together with debug pagealloc which right now forces
them to be off.
The only bit missing for that is a check for direct_gbpages=on
-Andi
next prev parent reply other threads:[~2008-01-31 16:24 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-29 5:06 [PATCH] [0/9] Latest GBPAGES patchkit for 2.6.25 Andi Kleen
2008-01-29 5:06 ` [PATCH] [1/9] Handle kernel near memory hole in clear_kernel_mapping Andi Kleen
2008-01-31 15:48 ` Thomas Gleixner
2008-01-31 16:22 ` Andi Kleen
2008-01-29 5:06 ` [PATCH] [2/9] GBPAGES: Add feature macros for the gbpages cpuid bit Andi Kleen
2008-01-29 5:06 ` [PATCH] [3/9] GBPAGES: Split LARGE_PAGE_SIZE/MASK into PUD_PAGE_SIZE/PMD_PAGE_SIZE Andi Kleen
2008-01-31 15:57 ` Thomas Gleixner
2008-01-29 5:06 ` [PATCH] [4/9] Add pgtable accessor functions for GB pages Andi Kleen
2008-01-29 5:06 ` [PATCH] [5/9] GBPAGES: Support gbpages in pagetable dump Andi Kleen
2008-01-29 5:06 ` [PATCH] [6/9] GBPAGES: Add gbpages support to lookup_address Andi Kleen
2008-01-31 16:02 ` Thomas Gleixner
2008-01-29 5:06 ` [PATCH] [7/9] Add an option to disable direct mapping gbpages and a global variable Andi Kleen
2008-01-31 16:12 ` Thomas Gleixner
2008-01-31 16:24 ` Andi Kleen [this message]
2008-01-31 17:00 ` Thomas Gleixner
2008-01-29 5:06 ` [PATCH] [8/9] GBPAGES: Implement gbpages support in change_page_attr() Andi Kleen
2008-01-29 5:06 ` [PATCH] [9/9] GBPAGES: Do kernel direct mapping at boot using GB pages Andi Kleen
2008-01-31 16:17 ` Thomas Gleixner
2008-01-31 16:38 ` Andi Kleen
2008-01-31 17:10 ` Thomas Gleixner
2008-01-31 17:39 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080131162400.GB25989@bingen.suse.de \
--to=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®