From: Adrian Bunk <bunk@kernel.org>
To: Andrew Morton <akpm@osdl.org>, Ingo Molnar <mingo@elte.hu>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: x86: Why have __copy_from_user_ll_nocache* been exported?
Date: Thu, 31 Jan 2008 22:14:30 +0200 [thread overview]
Message-ID: <20080131201430.GA9375@cs181133002.pp.htv.fi> (raw)
A commit that does nothing except for adding two unused EXPORT_SYMBOL's.
Without any rationale why they should be exported.
And that from a person who on the other hand wants to introduce
(and tries to force on other people) deprecation periods for unused
EXPORT_SYMBOL's.
Can we please get this reverted quickly?
TIA
Adrian
commit 914c82694cadbab511f2aee8a59c89be2938bace
Author: Andrew Morton <akpm@osdl.org>
Date: Wed Jan 30 23:27:57 2008 +0100
x86: export copy_from_user_ll_nocache[_nozero]
Cc: Neil Brown <neilb@cse.unsw.edu.au>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
diff --git a/arch/x86/lib/usercopy_32.c b/arch/x86/lib/usercopy_32.c
index 8bab2b2..9c4ffd5 100644
--- a/arch/x86/lib/usercopy_32.c
+++ b/arch/x86/lib/usercopy_32.c
@@ -817,6 +817,7 @@ unsigned long __copy_from_user_ll_nocache(void *to, const void __user *from,
#endif
return n;
}
+EXPORT_SYMBOL(__copy_from_user_ll_nocache);
unsigned long __copy_from_user_ll_nocache_nozero(void *to, const void __user *from,
unsigned long n)
@@ -831,6 +832,7 @@ unsigned long __copy_from_user_ll_nocache_nozero(void *to, const void __user *fr
#endif
return n;
}
+EXPORT_SYMBOL(__copy_from_user_ll_nocache_nozero);
/**
* copy_to_user: - Copy a block of data into user space.
next reply other threads:[~2008-01-31 20:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-31 20:14 Adrian Bunk [this message]
2008-01-31 20:31 ` Ingo Molnar
2008-02-01 9:50 ` Ingo Molnar
2008-01-31 21:05 ` Andrew Morton
2008-01-31 21:18 ` Ingo Molnar
2008-02-02 21:36 ` Adrian Bunk
2008-02-02 22:06 ` Andrew Morton
2008-02-04 19:58 ` Ingo Molnar
2008-02-10 22:16 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080131201430.GA9375@cs181133002.pp.htv.fi \
--to=bunk@kernel.org \
--cc=akpm@osdl.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®