From: Pavel Machek <pavel@ucw.cz>
To: Yinghai Lu <yhlu.kernel@gmail.com>
Cc: kernel list <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@elte.hu>, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: kill misleading comments in trampoline_*.S
Date: Fri, 1 Feb 2008 02:05:09 +0100 [thread overview]
Message-ID: <20080201010509.GB5112@elf.ucw.cz> (raw)
In-Reply-To: <86802c440801311702i1ac94b0m2af0bcdec6c9e866@mail.gmail.com>
On Thu 2008-01-31 17:02:29, Yinghai Lu wrote:
> On Jan 31, 2008 4:54 PM, Pavel Machek <pavel@ucw.cz> wrote:
> >
> >
> > Both trampolines actually *do* set up stack. (Is the "we jump into
> > compressed/head.S" comment still true?)
> >
> > Signed-off-by: Pavel Machek <pavel@suse.cz>
> >
> > diff --git a/arch/x86/kernel/trampoline_32.S b/arch/x86/kernel/trampoline_32.S
> > index 9bcc1c6..5398547 100644
> > --- a/arch/x86/kernel/trampoline_32.S
> > +++ b/arch/x86/kernel/trampoline_32.S
> > @@ -11,9 +11,6 @@
> > * trampoline page to make our stack and everything else
> > * is a mystery.
> > *
> > - * In fact we don't actually need a stack so we don't
> > - * set one up.
> > - *
> > * We jump into the boot/compressed/head.S code. So you'd
> > * better be running a compressed kernel image or you
> > * won't get very far.
>
> should be arch/x86/kernel/head_32.S
Thanks, fixed in my local copy. But that's separate problem. ;-).
Pavel
diff --git a/arch/x86/kernel/trampoline_32.S b/arch/x86/kernel/trampoline_32.S
index 9bcc1c6..6458067 100644
--- a/arch/x86/kernel/trampoline_32.S
+++ b/arch/x86/kernel/trampoline_32.S
@@ -11,12 +11,7 @@
* trampoline page to make our stack and everything else
* is a mystery.
*
- * In fact we don't actually need a stack so we don't
- * set one up.
- *
- * We jump into the boot/compressed/head.S code. So you'd
- * better be running a compressed kernel image or you
- * won't get very far.
+ * We jump into arch/x86/kernel/head_32.S.
*
* On entry to trampoline_data, the processor is in real mode
* with 16-bit addressing and 16-bit data. CS has some value
diff --git a/arch/x86/kernel/trampoline_64.S b/arch/x86/kernel/trampoline_64.S
index e30b67c..4aedd0b 100644
--- a/arch/x86/kernel/trampoline_64.S
+++ b/arch/x86/kernel/trampoline_64.S
@@ -10,9 +10,6 @@
* trampoline page to make our stack and everything else
* is a mystery.
*
- * In fact we don't actually need a stack so we don't
- * set one up.
- *
* On entry to trampoline_data, the processor is in real mode
* with 16-bit addressing and 16-bit data. CS has some value
* and IP is zero. Thus, data addresses need to be absolute
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2008-02-01 1:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-01 0:54 Pavel Machek
2008-02-01 1:02 ` Yinghai Lu
2008-02-01 1:05 ` Pavel Machek [this message]
2008-02-01 11:16 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080201010509.GB5112@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®