From: Andi Kleen <ak@suse.de>
To: tglx@linutronix.de, mingo@elte.hu, linux-kernel@vger.kernel.org
Subject: [PATCH] [3/3] CPA: Remove outdated comment in kernel_map_pages and add warning about recursion
Date: Fri, 1 Feb 2008 10:55:15 +0100 (CET) [thread overview]
Message-ID: <20080201095515.6C9061B416F@basil.firstfloor.org> (raw)
In-Reply-To: <200802011055.370582801@suse.de>
Signed-off-by: Andi Kleen <ak@suse.de>
---
arch/x86/mm/pageattr.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
Index: linux/arch/x86/mm/pageattr.c
===================================================================
--- linux.orig/arch/x86/mm/pageattr.c
+++ linux/arch/x86/mm/pageattr.c
@@ -556,6 +556,7 @@ static int __set_pages_np(struct page *p
__pgprot(_PAGE_PRESENT));
}
+/* This function recurses with unknown maximum depth */
void kernel_map_pages(struct page *page, int numpages, int enable)
{
if (PageHighMem(page))
@@ -571,10 +572,6 @@ void kernel_map_pages(struct page *page,
if (!debug_pagealloc_enabled)
return;
- /*
- * The return value is ignored - the calls cannot fail,
- * large pages are disabled at boot time:
- */
if (enable)
__set_pages_p(page, numpages);
else
prev parent reply other threads:[~2008-02-01 9:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-01 9:55 [PATCH] [1/3] CPA: Don't flush caches on CPUs that support self-snoop Andi Kleen
2008-02-01 9:55 ` [PATCH] [2/3] CPA: Only flush the cache if the caching attributes have changed Andi Kleen
2008-02-01 9:55 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080201095515.6C9061B416F@basil.firstfloor.org \
--to=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome