From: Sam Ravnborg <sam@ravnborg.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>,
Arjan van de Ven <arjan@linux.intel.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Holger Wolf <wolf@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] latencytop: Change Kconfig dependency.
Date: Fri, 1 Feb 2008 14:39:31 +0100 [thread overview]
Message-ID: <20080201133931.GB13349@uranus.ravnborg.org> (raw)
In-Reply-To: <20080201133228.GC11070@elte.hu>
On Fri, Feb 01, 2008 at 02:32:28PM +0100, Ingo Molnar wrote:
>
> * Sam Ravnborg <sam@ravnborg.org> wrote:
>
> > > config STACKTRACE_SUPPORT
> > > def_bool y
> > >
> > > +config HAVE_LATENCYTOP_SUPPORT
> > > + def_bool y
> > > +
> > No.
> > Please do:
> > config X86
> > + select HAVE_LATENCYTOP_SUPPORT
> >
> > Yes - this is a valid use of select.
>
> i see - and there's lots of other examples of this and other similar
> things in other architectures as well. Could we do that as a separate
> cleanup patch instead, to keep the Kconfig file consistently structured.
I would prefer new stuff to use the recommended method.
But I have no strong feelign for it and at the moment I am fed up
in Section mismatch warnings :-(
Sam
next prev parent reply other threads:[~2008-02-01 13:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-01 13:06 Heiko Carstens
2008-02-01 13:11 ` Ingo Molnar
2008-02-01 13:28 ` Sam Ravnborg
2008-02-01 13:32 ` Ingo Molnar
2008-02-01 13:39 ` Sam Ravnborg [this message]
2008-02-01 16:22 ` Heiko Carstens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080201133931.GB13349@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=arjan@linux.intel.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=schwidefsky@de.ibm.com \
--cc=wolf@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®