mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@tv-sign.ru>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Alexey Dobriyan <adobriyan@sw.ru>, Ingo Molnar <mingo@elte.hu>,
	Pavel Emelyanov <xemul@sw.ru>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] hrtimer_nanosleep: use -EINTR, not -ERESTARTNOHAND
Date: Fri, 1 Feb 2008 17:20:17 +0300	[thread overview]
Message-ID: <20080201142017.GA25774@tv-sign.ru> (raw)
In-Reply-To: <alpine.LFD.1.00.0802011438020.9204@apollo.tec.linutronix.de>

On 02/01, Thomas Gleixner wrote:
>
> On Fri, 1 Feb 2008, Oleg Nesterov wrote:
> 
> > hrtimer_nanosleep:
> > 
> > 	/* Absolute timers do not update the rmtp value and restart: */
> > 	return -ERESTARTNOHAND;
> > 
> > This is not right, -ERESTARTNOHAND means we will do restart if there is no
> > in fact pending signal, and worse, this restart will use the same unchanged
> > "__user *rmtp" parameter.
> 
> -ERESTARTNOHAND is safe here. We want to restart the timer.

Ah. I was greatly confused by the comment, it says "do not ... restart",
now I understand what this _actually_ means.

And yes, I was wrong. If restart is wanted, it is safe to use the original
*rqtp, the timer is HRTIMER_MODE_ABS.

Thanks Thomas!

Andrew, please ignore this patch.

Oleg.


      reply	other threads:[~2008-02-01 14:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-01 13:37 Oleg Nesterov
2008-02-01 13:50 ` Thomas Gleixner
2008-02-01 14:20   ` Oleg Nesterov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080201142017.GA25774@tv-sign.ru \
    --to=oleg@tv-sign.ru \
    --cc=a.p.zijlstra@chello.nl \
    --cc=adobriyan@sw.ru \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=xemul@sw.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®