mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Olof Johansson <olof@lixom.net>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	torvalds@linux-foundation.org
Cc: git-commits-head@vger.kernel.org, gregkh@suse.de
Subject: [PATCH] Fix fallout from PCI: PCIE ASPM support
Date: Fri, 1 Feb 2008 23:26:28 -0600	[thread overview]
Message-ID: <20080202052628.GB14936@lixom.net> (raw)
In-Reply-To: <200802020506.m1256gXG027547@hera.kernel.org>

On Sat, Feb 02, 2008 at 05:06:42AM +0000, Linux Kernel Mailing List wrote:

>     PCI: PCIE ASPM support

This one broke almost all defconfigs on powerpc, since they enable
CONFIG_EXPERIMENTAL and CONFIG_PCI, and this option defaults to y.

Make it default to 'n' like most other options, and make it depend on
ACPI. Take out the unneccessary default 'n' from the debug option as well.


Signed-off-by: Olof Johansson <olof@lixom.net>


diff --git a/drivers/pci/pcie/Kconfig b/drivers/pci/pcie/Kconfig
index 60104cf..4393bb3 100644
--- a/drivers/pci/pcie/Kconfig
+++ b/drivers/pci/pcie/Kconfig
@@ -32,8 +32,7 @@ source "drivers/pci/pcie/aer/Kconfig"
 #
 config PCIEASPM
 	bool "PCI Express ASPM support(Experimental)"
-	depends on PCI && EXPERIMENTAL
-	default y
+	depends on PCI && ACPI && EXPERIMENTAL
 	help
 	  This enables PCI Express ASPM (Active State Power Management) and
 	  Clock Power Management. ASPM supports state L0/L0s/L1.
@@ -42,7 +41,6 @@ config PCIEASPM
 config PCIEASPM_DEBUG
 	bool "Debug PCI Express ASPM"
 	depends on PCIEASPM
-	default n
 	help
 	  This enables PCI Express ASPM debug support. It will add per-device
 	  interface to control ASPM.

       reply	other threads:[~2008-02-02  5:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200802020506.m1256gXG027547@hera.kernel.org>
2008-02-02  5:26 ` Olof Johansson [this message]
2008-02-02  5:59   ` H. Peter Anvin
2008-02-02 15:39     ` Olof Johansson
2008-02-02 20:04   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080202052628.GB14936@lixom.net \
    --to=olof@lixom.net \
    --cc=git-commits-head@vger.kernel.org \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®