mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] x86: add function prototype to vm86.h
Date: Sat, 2 Feb 2008 10:04:34 +0100	[thread overview]
Message-ID: <20080202090434.GB17348@elte.hu> (raw)
In-Reply-To: <1201938485.1844.6.camel@brick>


* Harvey Harrison <harvey.harrison@gmail.com> wrote:

> Global functions should include their prototypes.

thanks, i've applied all three cleanup patches of yours.

one minor detail:

> +struct pt_regs * save_v86_state(struct kernel_vm86_regs *);

the proper form is:

   struct pt_regs *save_v86_state(struct kernel_vm86_regs *);

(note the lack of space)

	Ingo

      parent reply	other threads:[~2008-02-02  9:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-02  7:48 Harvey Harrison
2008-02-02  8:14 ` Li Zefan
2008-02-02  8:27   ` Harvey Harrison
2008-02-02  9:04 ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080202090434.GB17348@elte.hu \
    --to=mingo@elte.hu \
    --cc=harvey.harrison@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®