From: Sam Ravnborg <sam@ravnborg.org>
To: Peter Teoh <htmldeveloper@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: Section mismatch warning patch - microcode.c
Date: Sat, 2 Feb 2008 15:02:33 +0100 [thread overview]
Message-ID: <20080202140233.GA23877@uranus.ravnborg.org> (raw)
In-Reply-To: <804dabb00802020039j7ec7b66dlbf05fc9a80e1600a@mail.gmail.com>
On Sat, Feb 02, 2008 at 04:39:02PM +0800, Peter Teoh wrote:
> The following errors during compilation is corrected by the following
> patch (against the latest linus tree):
>
> WARNING: arch/x86/kernel/microcode.o(.exit.text+0x6): Section mismatch
> in reference from the function cleanup_module() to the variable
> .cpuinit.data:mc_cpu_notifier
I have missed this one when I did my last fix to that file.
But your patch is not good.
Annotating the microcode_exit() function with __init will
cause the kernel to drop the code long before we need it.
I will look into this later and post a fix for the warning.
Sam
> @@ -831,7 +831,7 @@ static int __init microcode_init (void)
> return 0;
> }
>
> -static void __exit microcode_exit (void)
> +static void __init microcode_exit (void)
> {
prev parent reply other threads:[~2008-02-02 14:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-02 8:39 Peter Teoh
2008-02-02 14:02 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080202140233.GA23877@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=htmldeveloper@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®