From: Sam Ravnborg <sam@ravnborg.org>
To: Peter Teoh <htmldeveloper@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: Some fixes for "Section mismatch" errors.
Date: Sat, 2 Feb 2008 21:42:33 +0100 [thread overview]
Message-ID: <20080202204233.GB26415@uranus.ravnborg.org> (raw)
In-Reply-To: <804dabb00802020800m61a6f87apb154cacc22275ef8@mail.gmail.com>
On Sun, Feb 03, 2008 at 12:00:29AM +0800, Peter Teoh wrote:
> Today, I pulled from linus tree, and compile with MANY section
> mismatches errors, eg, some of which are like the following:
>
> WARNING: sound/pci/rme9652/snd-hdsp.o(.text+0x1c9f): Section mismatch
> in reference from the function hdsp_check_for_firmware() to the
> function .devinit.text:hdsp_request_fw_loader()
> WARNING: sound/pci/rme9652/snd-hdsp.o(.text+0x35bf): Section mismatch
> in reference from the function snd_hdsp_proc_read() to the function
> .devinit.text:hdsp_request_fw_loader()
Your fix for this particular warning looks OK.
But always do:
-> One fix per patch
-> Include the warning in the patch descript that you fix
-> Explain why you fixed it the way you did it
Without this info it is too time consuming to try to review your patch
and I did nt look at the other changes you included.
Sam
prev parent reply other threads:[~2008-02-02 20:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-02 16:00 Peter Teoh
2008-02-02 20:42 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080202204233.GB26415@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=htmldeveloper@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®