From: Frank Seidel <frank@f-seidel.de>
To: Denis Cheng <crquan@gmail.com>
Cc: Jens Axboe <jens.axboe@oracle.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/block/: add __devinitdata to all pci_device_id table of block drivers
Date: Sun, 3 Feb 2008 10:43:41 +0100 [thread overview]
Message-ID: <200802031043.41724.frank@f-seidel.de> (raw)
In-Reply-To: <1202008347-5407-1-git-send-email-crquan@gmail.com>
On Sunday 03 February 2008 04:12, Denis Cheng wrote:
> --- a/drivers/block/cciss.c
> +++ b/drivers/block/cciss.c
> @@ -67,7 +67,7 @@ MODULE_LICENSE("GPL");
> #include <linux/cciss_ioctl.h>
>
> /* define the PCI info for the cards we can control */
> -static const struct pci_device_id cciss_pci_device_id[] = {
> +static const struct pci_device_id cciss_pci_device_id[] __devinitdata = {
it should be __devinitconst here
> --- a/drivers/block/cpqarray.c
> +++ b/drivers/block/cpqarray.c
> @@ -96,7 +96,7 @@ static struct board_type products[] = {
> };
>
> /* define the PCI info for the PCI cards this driver can control */
> -static const struct pci_device_id cpqarray_pci_device_id[] =
> +static const struct pci_device_id cpqarray_pci_device_id[] __devinitdata =
same here
> --- a/drivers/block/umem.c
> +++ b/drivers/block/umem.c
> @@ -1053,7 +1053,7 @@ static void mm_pci_remove(struct pci_dev *dev)
> pci_disable_device(dev);
> }
>
> -static const struct pci_device_id mm_pci_ids[] = {
> +static const struct pci_device_id mm_pci_ids[] __devinitdata = {
same here
Thanks,
Frank
prev parent reply other threads:[~2008-02-03 9:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-03 3:12 Denis Cheng
2008-02-03 9:43 ` Frank Seidel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802031043.41724.frank@f-seidel.de \
--to=frank@f-seidel.de \
--cc=crquan@gmail.com \
--cc=gregkh@suse.de \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®