From: Andi Kleen <andi@firstfloor.org>
To: Russell Leidich <rml@google.com>
Cc: Andi Kleen <andi@firstfloor.org>,
Torsten Kaiser <just.for.lkml@googlemail.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
valdis.kletnieks@vt.edu
Subject: Re: [PATCH] Remove Barcelona Thermal Throttling
Date: Mon, 4 Feb 2008 08:20:14 +0100 [thread overview]
Message-ID: <20080204072013.GB571@one.firstfloor.org> (raw)
In-Reply-To: <3f1a065b0802032213j713fe551t9a0642ea2b83994@mail.gmail.com>
On Sun, Feb 03, 2008 at 10:13:53PM -0800, Russell Leidich wrote:
> All,
>
> You can imagine my dismay when I recently learned that, after all our
> collective effort, hardware thermal throttling does not work reliably
> on Barcelona, according to AMD. Due to NDA restrictions, I am unable
> to provide further details.
Too bad. Hopefully that code will work then on the hypothetic
future parts with fixed throttling. Perhaps it would be better
to just remove it now and readd later.
All this reminds me you need to adjust the Kconfig dependencies
for K8_NB too to be always enabled with MCE_AMD.
Ideally on top of this patch with a || MCE_AMD
-Andi
---
Fix and simplify k8.c Kconfig dependencies
- Check for K8_NUMA instead of NUMA && PCI
- No need to check for x86_64 explicitely
Signed-off-by: Andi Kleen <ak@suse.de>
Index: linux/arch/x86/Kconfig
===================================================================
--- linux.orig/arch/x86/Kconfig
+++ linux/arch/x86/Kconfig
@@ -1540,7 +1540,7 @@ endif # X86_32
config K8_NB
def_bool y
- depends on AGP_AMD64 || (X86_64 && (GART_IOMMU || (PCI && NUMA)))
+ depends on AGP_AMD64 || GART_IOMMU || K8_NUMA
source "drivers/pcmcia/Kconfig"
next prev parent reply other threads:[~2008-02-04 6:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-04 6:13 Russell Leidich
2008-02-04 6:39 ` Russell Leidich
2008-02-04 7:20 ` Andi Kleen [this message]
2008-02-04 19:22 ` Russell Leidich
2008-02-12 19:21 ` Russell Leidich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080204072013.GB571@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=just.for.lkml@googlemail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rml@google.com \
--cc=tglx@linutronix.de \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®