From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757068AbYBGLzK (ORCPT ); Thu, 7 Feb 2008 06:55:10 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754371AbYBGLzA (ORCPT ); Thu, 7 Feb 2008 06:55:00 -0500 Received: from mx2.mail.elte.hu ([157.181.151.9]:47202 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752319AbYBGLzA (ORCPT ); Thu, 7 Feb 2008 06:55:00 -0500 Date: Thu, 7 Feb 2008 12:54:42 +0100 From: Ingo Molnar To: Andi Kleen Cc: Yinghai Lu , Thomas Gleixner , "H. Peter Anvin" , Linux Kernel Mailing List Subject: Re: [PATCH] x86_64: fix page table size Message-ID: <20080207115442.GB387@elte.hu> References: <200802061246.43413.yinghai.lu@sun.com> <200802061501.26533.yinghai.lu@sun.com> <20080206231226.GA6417@elte.hu> <200802062022.44069.yinghai.lu@sun.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Andi Kleen wrote: > Yinghai Lu writes: > > > > diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c > > index eb376b5..31f0e82 100644 > > --- a/arch/x86/mm/init_64.c > > +++ b/arch/x86/mm/init_64.c > > @@ -370,7 +370,7 @@ static void __init find_early_table_space(unsigned long end) > > > > puds = (end + PUD_SIZE - 1) >> PUD_SHIFT; > > tables = round_up(puds * sizeof(pud_t), PAGE_SIZE); > > - if (direct_gbpages) { > > + if (!direct_gbpages) { > > What tree did you use? The patch I submitted had > > if (direct_gbpages == GBP_ON) { yes, the bug was introduced in your original submission of gbpages. Ingo