From: Pierre Ossman <drzeus@drzeus.cx>
To: Frank Seidel <fseidel@suse.de>
Cc: Philip Langdale <philipl@overt.org>,
sdhci-devel@list.drzeus.cx, linux-kernel@vger.kernel.org,
Andrew de Quincey <adq_dvb@lidskialf.net>
Subject: Re: [PATCH v2] mmc: extend ricoh_mmc to support Ricoh RL5c476
Date: Thu, 7 Feb 2008 18:19:17 +0100 [thread overview]
Message-ID: <20080207181917.18b11638@poseidon.drzeus.cx> (raw)
In-Reply-To: <200802070920.39120.fseidel@suse.de>
[-- Attachment #1: Type: text/plain, Size: 590 bytes --]
On Thu, 7 Feb 2008 09:20:38 +0100
Frank Seidel <fseidel@suse.de> wrote:
> >
> > Wouldn't it be prudent to have a check that this is indeed a R5C832,
> > and a failure mode if it's none of the two known devices?
>
> Also thought about that, but as far as i can see this cannot happen since
> we only probe for those two devices and deny to continue if anything else
> /those two were not found in the beginning.
>
Can never be too careful though. :)
I've applied the patch for now. Feel free to keep digging and finding some docs for those regs though.
Rgds
Pierre
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
prev parent reply other threads:[~2008-02-07 17:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-31 17:38 [PATCH] " Frank Seidel
2008-02-02 7:16 ` Philip Langdale
2008-02-02 9:30 ` Frank Seidel
2008-02-04 18:25 ` Frank Seidel
2008-02-04 18:25 ` [PATCH] mmc: Handle suspend/resume in Ricoh MMC disabler (resent refreshed) Frank Seidel
2008-02-04 20:17 ` Philip Langdale
2008-02-04 18:25 ` [PATCH v2] mmc: extend ricoh_mmc to support Ricoh RL5c476 Frank Seidel
2008-02-04 20:18 ` Philip Langdale
2008-02-07 8:08 ` Pierre Ossman
2008-02-07 8:20 ` Frank Seidel
2008-02-07 17:19 ` Pierre Ossman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080207181917.18b11638@poseidon.drzeus.cx \
--to=drzeus@drzeus.cx \
--cc=adq_dvb@lidskialf.net \
--cc=fseidel@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=philipl@overt.org \
--cc=sdhci-devel@list.drzeus.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®