From: "Serge E. Hallyn" <serue@us.ibm.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Pavel Emelyanov <xemul@openvz.org>,
Linux Containers <containers@lists.osdl.org>,
Andrew Morton <akpm@linux-foundation.org>,
Paul Menage <menage@google.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][DOCUMENTATION] Minimal controller code for a quick start
Date: Thu, 7 Feb 2008 14:50:21 -0600 [thread overview]
Message-ID: <20080207205021.GB16628@sergelap.ibm.com> (raw)
In-Reply-To: <1202416137.6274.42.camel@lappy>
Quoting Peter Zijlstra (a.p.zijlstra@chello.nl):
>
> On Thu, 2008-02-07 at 18:37 +0300, Pavel Emelyanov wrote:
> > The Documentation/cgroups.txt file contains the info on how
> > to write some controller for cgroups subsystem, but even with
> > this, one need to write quite a lot of code before developing
> > the core (or copy-n-paste it from some other place).
> >
> > I propose to put this minimal controller into Documentation
> > directory to let people copy-n-paste a) from a known place and
> > b) a small piece of code.
> >
> > Besides, many people learn better reading an example rather
> > than/along with a document.
>
>
> While on the subject, could someone document struct cgroup_subsys. In
> particular, I've wondered why we have: cgroup_subsys::can_attach() and
The point of can_attach() is to decide whether an attach should be
permitted. kernel/ns_cgroup.c defines it.
> not use a return value in cgroup_subsys::attach()?
IIUC, by the point ->attach() is called, the task has already been placed
in the new cgroup, and we're just asking each subsystem to update any
relevant accounting.
-serge
next prev parent reply other threads:[~2008-02-07 20:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-07 15:37 Pavel Emelyanov
2008-02-07 20:28 ` Peter Zijlstra
2008-02-07 20:49 ` Paul Menage
2008-02-07 20:52 ` Peter Zijlstra
2008-02-07 20:50 ` Serge E. Hallyn [this message]
2008-02-07 20:45 ` Paul Menage
2008-02-08 8:09 ` Pavel Emelyanov
2008-02-07 20:47 ` Serge E. Hallyn
2008-02-08 9:28 ` Pavel Emelyanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080207205021.GB16628@sergelap.ibm.com \
--to=serue@us.ibm.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=containers@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=menage@google.com \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®