From: David Brownell <david-b@pacbell.net>
To: Guennadi Liakhovetski <g.liakhovetski@pengutronix.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] introduce is_valid_gpio() predicate and use it in gpiolib.c
Date: Sun, 10 Feb 2008 11:18:04 -0800 [thread overview]
Message-ID: <200802101118.04476.david-b@pacbell.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0802102002270.4417@axis700.grange>
I like this, but can't resist making the "Andrew Comment":
> --- a/include/asm-generic/gpio.h
> +++ b/include/asm-generic/gpio.h
> @@ -16,6 +16,8 @@
> #define ARCH_NR_GPIOS 256
> #endif
>
> +#define is_valid_gpio(gpio) ((unsigned int)(gpio) < ARCH_NR_GPIOS)
Please make this an inline C function. :)
> +
> struct seq_file;
>
> /**
>
prev parent reply other threads:[~2008-02-10 19:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-10 19:12 Guennadi Liakhovetski
2008-02-10 19:18 ` David Brownell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802101118.04476.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=g.liakhovetski@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®