From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760315AbYBKS3p (ORCPT ); Mon, 11 Feb 2008 13:29:45 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760002AbYBKS3O (ORCPT ); Mon, 11 Feb 2008 13:29:14 -0500 Received: from one.firstfloor.org ([213.235.205.2]:36581 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757315AbYBKS3N (ORCPT ); Mon, 11 Feb 2008 13:29:13 -0500 Date: Mon, 11 Feb 2008 20:04:38 +0100 From: Andi Kleen To: Linus Torvalds Cc: Andi Kleen , bzolnier@gmail.com, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Prevent IDE boot ops on NUMA system in mainline Message-ID: <20080211190438.GB21824@one.firstfloor.org> References: <20080211003520.GA32082@basil.nowhere.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 11, 2008 at 09:37:18AM -0800, Linus Torvalds wrote: > > > On Mon, 11 Feb 2008, Linus Torvalds wrote: > > > > So we should probably make pcibus_to_node() be an inline function for that > > case > > Or, we could just do the ugliest patch ever, namely > > -#define pcibus_to_node(node) (-1) > +#define pcibus_to_node(node) ((int)(long)(node),-1) > > Wow. It's so ugly it's almost wraps around and comes out the other sides > and looks pretty. (void)arg, ... is better. Trick originally from Jan Beulich I think (his code is always a good source for useful new C tricks) -Andi