mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: tony@bakeyournoodle.com (Tony Breeds)
To: "Toralf Förster" <toralf.foerster@gmx.de>
Cc: video4linux-list@redhat.com, linux-kernel@vger.kernel.org,
	Michael Krufky <mkrufky@linuxtv.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: build #345 issue for v2.6.25-rc1 in tuner-core.c
Date: Tue, 12 Feb 2008 11:42:51 +1100	[thread overview]
Message-ID: <20080212004251.GT6887@bakeyournoodle.com> (raw)
In-Reply-To: <200802111154.31760.toralf.foerster@gmx.de>

On Mon, Feb 11, 2008 at 11:54:31AM +0100, Toralf Förster wrote:
> 
> Hello,
> 
> the build with the attached .config failed, make ending with:
> ...
>   MODPOST vmlinux.o
> WARNING: modpost: Found 12 section mismatch(es).
> To see full details build your kernel with:
> 'make CONFIG_DEBUG_SECTION_MISMATCH=y'
>   GEN     .version
>   CHK     include/linux/compile.h
>   UPD     include/linux/compile.h
>   CC      init/version.o
>   LD      init/built-in.o
>   LD      .tmp_vmlinux1
> drivers/built-in.o: In function `set_type':
> tuner-core.c:(.text+0x8879d): undefined reference to `xc5000_attach'
> make: *** [.tmp_vmlinux1] Error 1

<snip>
Fix Build error for xc5000 tuner when built as module.

Signed-off-by: Tony Breeds <tony@bakeyournoodle.com>

---
Not 100% certain this is correct but it works for me :) Michael?

 drivers/media/dvb/frontends/xc5000.h |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/media/dvb/frontends/xc5000.h b/drivers/media/dvb/frontends/xc5000.h
index e0e8456..32a5f1c 100644
--- a/drivers/media/dvb/frontends/xc5000.h
+++ b/drivers/media/dvb/frontends/xc5000.h
@@ -45,7 +45,8 @@ struct xc5000_config {
 /* xc5000 callback command */
 #define XC5000_TUNER_RESET		0
 
-#if defined(CONFIG_DVB_TUNER_XC5000) || defined(CONFIG_DVB_TUNER_XC5000_MODULE)
+#if defined(CONFIG_DVB_TUNER_XC5000) || \
+    (defined(CONFIG_DVB_TUNER_XC5000_MODULE) && defined(MODULE))
 extern struct dvb_frontend* xc5000_attach(struct dvb_frontend *fe,
 					  struct i2c_adapter *i2c,
 					  struct xc5000_config *cfg);

  reply	other threads:[~2008-02-12  0:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-11 10:54 Toralf Förster
2008-02-12  0:42 ` Tony Breeds [this message]
     [not found]   ` <47B105B8.7010900@linuxtv.org>
2008-02-12 14:59     ` Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080212004251.GT6887@bakeyournoodle.com \
    --to=tony@bakeyournoodle.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mkrufky@linuxtv.org \
    --cc=toralf.foerster@gmx.de \
    --cc=video4linux-list@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome