From: "Mark M. Hoffman" <mhoffman@lightlink.com>
To: Jean Delvare <khali@linux-fr.org>
Cc: Greg KH <greg@kroah.com>, Yinghai Lu <yhlu.kernel@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
lm-sensors@lm-sensors.org
Subject: Re: [PATCH] hwmon: (adm1026) Properly terminate sysfs groups (Was: panic about sysfs with adm1026)
Date: Wed, 13 Feb 2008 08:17:55 -0500 [thread overview]
Message-ID: <20080213131755.GG1154@jupiter.solarsys.private> (raw)
In-Reply-To: <20080210190115.2ebd4124@hyperion.delvare>
Hi Jean et. al.:
* Jean Delvare <khali@linux-fr.org> [2008-02-10 19:01:15 +0100]:
> The missing NULL at the end of two sysfs file groups causes a kernel
> crash when calling sysfs_create_group().
>
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
> ---
> drivers/hwmon/adm1026.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> --- linux-2.6.25-rc0.orig/drivers/hwmon/adm1026.c 2008-02-10 11:21:54.000000000 +0100
> +++ linux-2.6.25-rc0/drivers/hwmon/adm1026.c 2008-02-10 18:51:00.000000000 +0100
> @@ -1624,6 +1624,7 @@ static struct attribute *adm1026_attribu
> &dev_attr_temp3_crit_enable.attr,
> &dev_attr_temp3_auto_point1_pwm.attr,
> &dev_attr_temp3_auto_point2_pwm.attr,
> + NULL
> };
>
> static const struct attribute_group adm1026_group_temp3 = {
> @@ -1639,6 +1640,7 @@ static struct attribute *adm1026_attribu
> &sensor_dev_attr_in9_max.dev_attr.attr,
> &sensor_dev_attr_in9_min.dev_attr.attr,
> &sensor_dev_attr_in9_alarm.dev_attr.attr,
> + NULL
> };
>
> static const struct attribute_group adm1026_group_in8_9 = {
Applied to hwmon-2.6.git/testing, thanks.
--
Mark M. Hoffman
mhoffman@lightlink.com
prev parent reply other threads:[~2008-02-13 13:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-10 7:55 panic about sysfs with adm1026 Yinghai Lu
2008-02-10 17:10 ` Greg KH
[not found] ` <20080210190115.2ebd4124@hyperion.delvare>
2008-02-10 20:31 ` [PATCH] hwmon: (adm1026) Properly terminate sysfs groups (Was: panic about sysfs with adm1026) Yinghai Lu
2008-02-11 23:39 ` Yinghai Lu
2008-02-12 8:27 ` Jean Delvare
2008-02-12 15:27 ` Greg KH
2008-02-12 15:37 ` Jean Delvare
2008-02-12 16:02 ` Greg KH
2008-02-12 16:13 ` [lm-sensors] " MillTek
2008-02-13 13:17 ` Mark M. Hoffman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080213131755.GG1154@jupiter.solarsys.private \
--to=mhoffman@lightlink.com \
--cc=greg@kroah.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®