From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764842AbYBNEE5 (ORCPT ); Wed, 13 Feb 2008 23:04:57 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754758AbYBNEEs (ORCPT ); Wed, 13 Feb 2008 23:04:48 -0500 Received: from smtp2.linux-foundation.org ([207.189.120.14]:38507 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754557AbYBNEEr (ORCPT ); Wed, 13 Feb 2008 23:04:47 -0500 Date: Wed, 13 Feb 2008 20:04:39 -0800 From: Andrew Morton To: Harvey Harrison Cc: Russell King , LKML Subject: Re: [PATCH] adfs: trivial sparse fix Message-Id: <20080213200439.1a501f83.akpm@linux-foundation.org> In-Reply-To: <1202961135.16621.1.camel@brick> References: <1202954868.18204.47.camel@brick> <20080213193945.91b42a8d.akpm@linux-foundation.org> <1202961135.16621.1.camel@brick> X-Mailer: Sylpheed 2.4.1 (GTK+ 2.8.17; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 13 Feb 2008 19:52:12 -0800 Harvey Harrison wrote: > On Wed, 2008-02-13 at 19:39 -0800, Andrew Morton wrote: > > On Wed, 13 Feb 2008 18:07:48 -0800 Harvey Harrison wrote: > > > > > fs/adfs/dir_f.c:126:4: warning: do-while statement is not a compound statement > > > > > > Signed-off-by: Harvey Harrison > > > --- > > > fs/adfs/dir_f.c | 4 ++-- > > > 1 files changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/fs/adfs/dir_f.c b/fs/adfs/dir_f.c > > > index b9b2b27..ea7df21 100644 > > > --- a/fs/adfs/dir_f.c > > > +++ b/fs/adfs/dir_f.c > > > @@ -122,9 +122,9 @@ adfs_dir_checkbyte(const struct adfs_dir *dir) > > > ptr.ptr8 = bufoff(bh, i); > > > end.ptr8 = ptr.ptr8 + last - i; > > > > > > - do > > > + do { > > > dircheck = *ptr.ptr8++ ^ ror13(dircheck); > > > - while (ptr.ptr8 < end.ptr8); > > > + } while (ptr.ptr8 < end.ptr8); > > > } > > > > > > > eh? It's sparse which needs fixing here, surely? > > Well, I only 'fixed' it this way to match the surrounding code. The > warning is a little odd. > Yup, well, I changed the title to something sufficiently rude to get a reaction from Linus when it crosses his desk. We'll see ;)