From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Adrian Bunk <bunk@kernel.org>
Cc: Len Brown <len.brown@intel.com>, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] thinkpad_acpi.c: make 2 functions static
Date: Wed, 13 Feb 2008 21:03:21 -0200 [thread overview]
Message-ID: <20080213230321.GC26196@khazad-dum.debian.net> (raw)
In-Reply-To: <20080213213006.GV3383@cs181133002.pp.htv.fi>
On Wed, 13 Feb 2008, Adrian Bunk wrote:
> this_patch_makes_the_needlessly_global_hotkey_wakeup_reason_notify_change_and_hotkey_wakeup_hotunplug_complete_notify_change_static
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
> ---
>
> ;-)
>
> da7d9b1a1d74ba5265d02e316a215540fe2daf19 diff --git a/drivers/misc/thinkpad_acpi.c b/drivers/misc/thinkpad_acpi.c
> index 7ba1aca..e2c7edd 100644
> --- a/drivers/misc/thinkpad_acpi.c
> +++ b/drivers/misc/thinkpad_acpi.c
> @@ -1689,7 +1689,7 @@ static ssize_t hotkey_wakeup_reason_show(struct device *dev,
> static struct device_attribute dev_attr_hotkey_wakeup_reason =
> __ATTR(wakeup_reason, S_IRUGO, hotkey_wakeup_reason_show, NULL);
>
> -void hotkey_wakeup_reason_notify_change(void)
> +static void hotkey_wakeup_reason_notify_change(void)
> {
> if (tp_features.hotkey_mask)
> sysfs_notify(&tpacpi_pdev->dev.kobj, NULL,
> @@ -1708,7 +1708,7 @@ static struct device_attribute dev_attr_hotkey_wakeup_hotunplug_complete =
> __ATTR(wakeup_hotunplug_complete, S_IRUGO,
> hotkey_wakeup_hotunplug_complete_show, NULL);
>
> -void hotkey_wakeup_hotunplug_complete_notify_change(void)
> +static void hotkey_wakeup_hotunplug_complete_notify_change(void)
> {
> if (tp_features.hotkey_mask)
> sysfs_notify(&tpacpi_pdev->dev.kobj, NULL,
>
Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
---
That said, I have no idea what toshiba-acpi has to do with the above patch
;-)
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
next prev parent reply other threads:[~2008-02-13 23:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-13 21:30 Adrian Bunk
2008-02-13 23:03 ` Henrique de Moraes Holschuh [this message]
2008-02-14 0:57 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080213230321.GC26196@khazad-dum.debian.net \
--to=hmh@hmh.eng.br \
--cc=bunk@kernel.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®