From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Robert Hancock <hancockr@shaw.ca>,
Andrew Morton <akpm@linux-foundation.org>,
avuton@gmail.com, yakui.zhao@intel.com, shaohua.li@intel.com,
trenn@suse.de,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
alsa-devel@alsa-project.org
Subject: Re: a7839e96 (PNP: increase max resources) breaks my ALSA intel8x0 sound card
Date: Thu, 14 Feb 2008 11:51:39 -0700 [thread overview]
Message-ID: <200802141151.40396.bjorn.helgaas@hp.com> (raw)
In-Reply-To: <200802051312.47074.bjorn.helgaas@hp.com>
On Tuesday 05 February 2008 01:12:46 pm Bjorn Helgaas wrote:
> On Tuesday 05 February 2008 11:15:12 am Linus Torvalds wrote:
> > No, you don't need any quirks: you just do an "insert_resource()" and
> > ignore the error return. If the (bogus) PnP resource clashes with the
> > (correct) hardware PCI resource, the insert will simply fail. No quirks
> > needed.
> I'll play with your insert_resource() idea and see if I can figure
> something out.
Sorry for the delay. I did work on this, but I don't see how this
can work. pcibios_init() marks its reservations as not busy, so the
subsequent PNP request doesn't fail, even if it clashes.
The PNP system driver is an fs_initcall(), so it already happens after
pcibios_init():
1) register ACPI PCI root bridge driver, which enumerates PCI
devices behind the bridge
2) pcibios_init() -> pcibios_resource_survey() -> request_resource()
3) register PNP system driver -> request_region()
4) register intel8x0 sound driver and reserve resources
(conflict happens here)
We have reservations in this order:
febf8000-febfbfff : 0000:00:1b.0 -- from pcibios_resource_survey (!busy)
febfa000-febfac00 : pnp 00:08 -- from PNP system driver (!busy)
febf8000-febfbfff : ICH HD audio -- fails because it spans the PNP region
The PNP reservation succeeds even though the PCI reservation has
already happened, so I don't see how we can do this without a
quirk that ignores the bogus PNP resources.
Bjorn
next prev parent reply other threads:[~2008-02-14 18:50 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <fa.Kmpf0B4W44W1VefIME7+BnfUouY@ifi.uio.no>
2008-01-27 18:17 ` Robert Hancock
2008-01-31 22:58 ` Andrew Morton
2008-02-01 0:14 ` Robert Hancock
2008-02-01 0:50 ` Linus Torvalds
2008-02-04 17:39 ` Bjorn Helgaas
2008-02-04 18:18 ` Linus Torvalds
2008-02-04 20:41 ` Bjorn Helgaas
2008-02-04 21:16 ` Linus Torvalds
2008-02-05 7:03 ` Bjorn Helgaas
2008-02-05 16:46 ` Avuton Olrich
2008-02-05 18:15 ` Linus Torvalds
2008-02-05 20:12 ` Bjorn Helgaas
2008-02-13 22:33 ` Avuton Olrich
2008-02-14 18:51 ` Bjorn Helgaas [this message]
2008-02-14 19:42 ` Linus Torvalds
2008-02-14 20:07 ` Bjorn Helgaas
2008-02-14 20:26 ` Linus Torvalds
2008-02-14 21:01 ` Bjorn Helgaas
2008-02-14 21:37 ` Linus Torvalds
2008-02-14 22:28 ` Bjorn Helgaas
2008-02-14 22:57 ` Linus Torvalds
2008-02-14 23:14 ` Linus Torvalds
2008-02-15 0:13 ` Bjorn Helgaas
2008-02-15 0:40 ` Linus Torvalds
2008-02-27 17:43 ` Bjorn Helgaas
2008-01-27 14:40 Avuton Olrich
2008-01-27 21:50 ` Linus Torvalds
2008-01-28 1:15 ` Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802141151.40396.bjorn.helgaas@hp.com \
--to=bjorn.helgaas@hp.com \
--cc=akpm@linux-foundation.org \
--cc=alsa-devel@alsa-project.org \
--cc=avuton@gmail.com \
--cc=hancockr@shaw.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=shaohua.li@intel.com \
--cc=torvalds@linux-foundation.org \
--cc=trenn@suse.de \
--cc=yakui.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®