From: Sam Ravnborg <sam@ravnborg.org>
To: Erez Zadok <ezk@cs.sunysb.edu>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] unhide CONFIG_DEBUG_SECTION_MISMATCH
Date: Thu, 14 Feb 2008 22:11:17 +0100 [thread overview]
Message-ID: <20080214211117.GH21894@uranus.ravnborg.org> (raw)
In-Reply-To: <200802142105.m1EL5EOo006085@agora.fsl.cs.sunysb.edu>
On Thu, Feb 14, 2008 at 04:05:14PM -0500, Erez Zadok wrote:
> In message <20080214210003.GF21894@uranus.ravnborg.org>, Sam Ravnborg writes:
> > On Thu, Feb 14, 2008 at 03:54:04PM -0500, Erez Zadok wrote:
> > > Using: v2.6.25-rc1-120-ge760e71
> > >
> > > In a normal compilation, I might this message:
> > >
> > > ...
> > > MODPOST vmlinux.o
> > > WARNING: modpost: Found 4 section mismatch(es).
> > > To see full details build your kernel with:
> > > 'make CONFIG_DEBUG_SECTION_MISMATCH=y'
> > > ...
> > >
> > > I can indeed try to re-make, passing CONFIG_DEBUG_SECTION_MISMATCH=y on the
> > > command line, but I can't turn on the option in my .config. That's because
> > > the option depends on "UNDEFINED". (Was that an attempt to "hide" the
> > > option? Why?) The following small patch allows me to set the option in my
> > > .config.
> >
> > It was done so on purpose.
> > The rationale here is that we yet have too many section mismatch for
> > a typical build to pass my "good stomach" test.
> > So until we get down on an acceptable level we should not be
> > too noisy.
> > And I wanted it to be turned off also for allyesconfig builds.
> >
> > I hope to spend time on the reaming warnings soon but the
> > option will not be enabled until latest next mergewindow.
> >
> > You could argue that I could have doen this in better ways
> > The present version was just simple.
> >
> > Sam
>
> Thanks, Sam. That explains it. Perhaps a small comment next to the Kconfig
> entry might help explain why the option is "hidden" for now, so others won't
> bother unhiding it again.
Something like this?
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index a370fe8..8a6b514 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -81,6 +81,8 @@ config HEADERS_CHECK
config DEBUG_SECTION_MISMATCH
bool "Enable full Section mismatch analysis"
+# Hide this option until we are down to a reasonable amount of warnings
+# for a typical kernel configuration
depends on UNDEFINED
help
Sam
prev parent reply other threads:[~2008-02-14 21:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-14 20:54 Erez Zadok
2008-02-14 20:57 ` Roland Dreier
2008-02-14 21:00 ` Sam Ravnborg
2008-02-14 21:05 ` Erez Zadok
2008-02-14 21:11 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080214211117.GH21894@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=akpm@linux-foundation.org \
--cc=ezk@cs.sunysb.edu \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®