From: Luca Risolia <luca.risolia@studio.unibo.it>
To: Roel Kluin <12o3l@tiscali.nl>
Cc: linux-usb@vger.kernel.org, video4linux-list@redhat.com,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] drivers/media/video/sn9c102/sn9c102_core.c Fix Unlikely(x) == y
Date: Sat, 16 Feb 2008 19:09:44 +0100 [thread overview]
Message-ID: <200802161909.44284.luca.risolia@studio.unibo.it> (raw)
In-Reply-To: <47B70B6A.1070404@tiscali.nl>
It's okay, thanks.
Reviewed-by: Luca Risolia <luca.risolia@studio.unibo.it>
---
On Saturday 16 February 2008 17:12:26 Roel Kluin wrote:
> The patch below was not yet tested. If it's incorrect, please comment.
> ---
> Fix Unlikely(x) == y
>
> Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
> ---
> diff --git a/drivers/media/video/sn9c102/sn9c102_core.c
> b/drivers/media/video/sn9c102/sn9c102_core.c index c40ba3a..66313b1 100644
> --- a/drivers/media/video/sn9c102/sn9c102_core.c
> +++ b/drivers/media/video/sn9c102/sn9c102_core.c
> @@ -528,7 +528,7 @@ sn9c102_find_sof_header(struct sn9c102_device* cam,
> void* mem, size_t len)
>
> /* Search for the SOF marker (fixed part) in the header */
> for (j = 0, b=cam->sof.bytesread; j+b < sizeof(marker); j++) {
> - if (unlikely(i+j) == len)
> + if (unlikely(i+j == len))
> return NULL;
> if (*(m+i+j) == marker[cam->sof.bytesread]) {
> cam->sof.header[cam->sof.bytesread] = *(m+i+j);
prev parent reply other threads:[~2008-02-16 18:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-16 16:12 Roel Kluin
2008-02-16 18:09 ` Luca Risolia [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802161909.44284.luca.risolia@studio.unibo.it \
--to=luca.risolia@studio.unibo.it \
--cc=12o3l@tiscali.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®