From: Arjan van de Ven <arjan@infradead.org>
To: Frans Pop <elendil@planet.nl>
Cc: linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: Unable to continue testing of 2.6.25
Date: Sun, 17 Feb 2008 12:46:50 -0800 [thread overview]
Message-ID: <20080217124650.576990ce@laptopd505.fenrus.org> (raw)
In-Reply-To: <200802171025.30590.elendil@planet.nl>
On Sun, 17 Feb 2008 10:25:30 +0100
Frans Pop <elendil@planet.nl> wrote:
> Yesterday, after spending quite a few hours over the last days on
> bisecting some serious regressions and finding workarounds for them,
> I thought I could start using 2.6.25-rc2 as the new kernel for my
> desktop. Unfortunately I found that I cannot because it would make my
> other main activity - working on the Debian installation system -
> impossible.
>
> For my work on the Debian Installer I heavily rely on emulators to
> run test installs and ATM my emulator of choice is VirtualBox (the
> fully open "ose" version). This requires the vboxdrv kernel module,
> but unfortunately: vboxdrv: Unknown symbol change_page_attr
>
> At first I traced this to:
> e1271f68
> x86: deprecate change_page_attr() for drivers
> With the introduction of the new API, no driver or non-archcore code
> needs to use c-p-a anymore, so this patch also deprecates the
> EXPORT_SYMBOL of CPA (it's a horrible API after all).
> which had:
> -EXPORT_SYMBOL(change_page_attr);
> +EXPORT_UNUSED_SYMBOL(change_page_attr); /* to be removed in 2.6.27 */
>
> Which seemed entirely reasonable but left me wondering about the
> error I got.
>
> But then I found:
> d1028a15
> x86: make various pageattr.c functions static
> change_page_attr_add is only used in pageattr.c now, so we can
> make this function static.
> change_page_attr() isn't used anywere at all anymore; this function
> is a really bad API anyway so just remove the bloat entirely.
>
> Which removed the entire function (without even properly mentioning
> it in the shortlog).
>
the initial plan was for a depreciation period. Sadly it was untenable since the API
was changing entirely to fix bugs and add a really important feature
(the ability to clflush the exact range rather than wbinvd'ing the caches of all cpus in the system),
at which point we had to pull the function right away.
As for virtualbox; a fix for that already exists, and it consists of removing 25 lines of workarounds
for c-p-a bugs, and just using set_memory_x / set_memory_nx.
--
If you want to reach me at my work email, use arjan@linux.intel.com
For development, discussion and tips for power savings,
visit http://www.lesswatts.org
next prev parent reply other threads:[~2008-02-17 20:47 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-17 9:25 Frans Pop
2008-02-17 13:16 ` Adrian Bunk
2008-02-17 19:24 ` Tilman Schmidt
2008-02-17 19:44 ` Adrian Bunk
2008-02-17 20:38 ` Paul Jackson
2008-02-17 20:51 ` Arjan van de Ven
2008-02-19 22:41 ` Frans Pop
2008-02-18 2:33 ` David Miller
2008-02-18 11:40 ` Tilman Schmidt
2008-02-18 12:27 ` Andi Kleen
2008-02-19 21:55 ` Frans Pop
2008-02-19 21:59 ` Arjan van de Ven
2008-02-19 22:15 ` Harvey Harrison
2008-02-19 22:19 ` Adrian Bunk
2008-02-19 22:49 ` Frans Pop
2008-02-17 20:46 ` Arjan van de Ven [this message]
2008-02-18 12:31 ` Andi Kleen
2008-02-18 16:50 ` Arjan van de Ven
2008-02-18 17:11 ` Andi Kleen
2008-02-18 17:32 ` Arjan van de Ven
2008-02-18 18:40 ` Alan Cox
2008-02-18 18:52 ` Arjan van de Ven
2008-02-18 20:15 ` Alan Cox
2008-02-18 18:52 ` Andi Kleen
2008-02-18 18:32 ` Arjan van de Ven
2008-02-18 19:18 ` Ingo Molnar
2008-02-19 9:35 ` Andi Kleen
2008-02-18 18:53 ` Roland Dreier
2008-02-18 19:07 ` Arjan van de Ven
2008-02-18 19:18 ` Roland Dreier
2008-02-19 19:42 ` Siddha, Suresh B
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080217124650.576990ce@laptopd505.fenrus.org \
--to=arjan@infradead.org \
--cc=elendil@planet.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®