From: Christoph Hellwig <hch@infradead.org>
To: Adrian Bunk <bunk@kernel.org>
Cc: hch@infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] fs/freevxfs/: proper externs
Date: Sun, 17 Feb 2008 08:06:12 -0500 [thread overview]
Message-ID: <20080217130611.GA32209@infradead.org> (raw)
In-Reply-To: <20080217082028.GS3848@cs181133002.pp.htv.fi>
On Sun, Feb 17, 2008 at 10:20:28AM +0200, Adrian Bunk wrote:
> This patch moves the extern declarations of several structs to vxfs_extern.h
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
ACK.
>
> ---
>
> fs/freevxfs/vxfs_extern.h | 5 +++++
> fs/freevxfs/vxfs_immed.c | 1 +
> fs/freevxfs/vxfs_inode.c | 5 -----
> 3 files changed, 6 insertions(+), 5 deletions(-)
>
> d5e4ab16e3f3550022ee77df02a0602bc03642ee diff --git a/fs/freevxfs/vxfs_extern.h b/fs/freevxfs/vxfs_extern.h
> index 2b46064..50ab5ee 100644
> --- a/fs/freevxfs/vxfs_extern.h
> +++ b/fs/freevxfs/vxfs_extern.h
> @@ -50,7 +50,11 @@ extern daddr_t vxfs_bmap1(struct inode *, long);
> /* vxfs_fshead.c */
> extern int vxfs_read_fshead(struct super_block *);
>
> +/* vxfs_immed.c */
> +extern const struct inode_operations vxfs_immed_symlink_iops;
> +
> /* vxfs_inode.c */
> +extern const struct address_space_operations vxfs_immed_aops;
> extern struct kmem_cache *vxfs_inode_cachep;
> extern void vxfs_dumpi(struct vxfs_inode_info *, ino_t);
> extern struct inode * vxfs_get_fake_inode(struct super_block *,
> @@ -69,6 +73,7 @@ extern const struct file_operations vxfs_dir_operations;
> extern int vxfs_read_olt(struct super_block *, u_long);
>
> /* vxfs_subr.c */
> +extern const struct address_space_operations vxfs_aops;
> extern struct page * vxfs_get_page(struct address_space *, u_long);
> extern void vxfs_put_page(struct page *);
> extern struct buffer_head * vxfs_bread(struct inode *, int);
> diff --git a/fs/freevxfs/vxfs_immed.c b/fs/freevxfs/vxfs_immed.c
> index 8a5959a..c36aeaf 100644
> --- a/fs/freevxfs/vxfs_immed.c
> +++ b/fs/freevxfs/vxfs_immed.c
> @@ -35,6 +35,7 @@
> #include <linux/namei.h>
>
> #include "vxfs.h"
> +#include "vxfs_extern.h"
> #include "vxfs_inode.h"
>
>
> diff --git a/fs/freevxfs/vxfs_inode.c b/fs/freevxfs/vxfs_inode.c
> index ad88d23..9f3f2ce 100644
> --- a/fs/freevxfs/vxfs_inode.c
> +++ b/fs/freevxfs/vxfs_inode.c
> @@ -41,11 +41,6 @@
> #include "vxfs_extern.h"
>
>
> -extern const struct address_space_operations vxfs_aops;
> -extern const struct address_space_operations vxfs_immed_aops;
> -
> -extern const struct inode_operations vxfs_immed_symlink_iops;
> -
> struct kmem_cache *vxfs_inode_cachep;
>
>
>
---end quoted text---
prev parent reply other threads:[~2008-02-17 13:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-17 8:20 Adrian Bunk
2008-02-17 13:06 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080217130611.GA32209@infradead.org \
--to=hch@infradead.org \
--cc=bunk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®