mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Roland McGrath <roland@redhat.com>
Cc: Rene Herman <rene.herman@keyaccess.nl>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	linux-kbuild@vger.kernel.org
Subject: Re: 2.6.25-rc2 vdso_install breaks user "make install"
Date: Sun, 17 Feb 2008 20:35:14 +0100	[thread overview]
Message-ID: <20080217193514.GJ14588@uranus.ravnborg.org> (raw)
In-Reply-To: <20080216113610.GB11362@uranus.ravnborg.org>

On Sat, Feb 16, 2008 at 12:36:10PM +0100, Sam Ravnborg wrote:
> On Fri, Feb 15, 2008 at 07:42:11PM -0800, Roland McGrath wrote:
> > Perhaps it makes more sense to have vdso_install be a dependency of
> > modules_install rather than install, since they both put things in /lib/modules.
> > The installed vdso images are potentially useful for a kernel when you
> > aren't bothering to build or install any modules, but those images are only
> > ever useful for sophisticated debugging uses anyway.
> > 
> > Sam, any thoughts?  (See arch/x86/Makefile and arch/powerpc/Makefile.)
> 
> Installing the vdso files as aprt of modules_install would be
> unintuitive as this has nothing to do with modules.
> 
> And since you wrote:
> > useful for sophisticated debugging uses anyway
> I suggest to make the vdso_install step independent as
> in following patch.
> [Note: help docs needs to mention the new target].
> 
> This solves the issue at ahnd and still gives us the posibility
> to install the files should they be needed.

Roland - if you agree will you please submit the patch
to the x86 people.
You can tag it:
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
or Acked-by: Sam Ravnborg <sam@ravnborg.org>

as you like.

	Sam

  reply	other threads:[~2008-02-17 19:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-16  3:31 Rene Herman
2008-02-16  3:42 ` Roland McGrath
2008-02-16  3:53   ` Rene Herman
2008-02-16 11:36   ` Sam Ravnborg
2008-02-17 19:35     ` Sam Ravnborg [this message]
2008-02-17 19:53       ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080217193514.GJ14588@uranus.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rene.herman@keyaccess.nl \
    --cc=roland@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®