mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Mel Gorman <mel@csn.ul.ie>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux Kernel Development <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: setup_usemap() must be __meminit
Date: Sun, 17 Feb 2008 20:43:20 +0100	[thread overview]
Message-ID: <20080217194320.GL14588@uranus.ravnborg.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0802171329400.6172@anakin>

On Sun, Feb 17, 2008 at 01:31:14PM +0100, Geert Uytterhoeven wrote:
> On Sun, 17 Feb 2008, Geert Uytterhoeven wrote:
> > On m68k (CONFIG_SPARSEMEM is not set), I get:
> > 
> >     WARNING: vmlinux.o(.meminit.text+0x36c): Section mismatch in reference from the function free_area_init_core() to the function .init.text:setup_usemap()
> >     The function __meminit free_area_init_core() references
> >     a function __init setup_usemap().
> >     If free_area_init_core is only used by setup_usemap then
> >     annotate free_area_init_core with a matching annotation.
> > 
> > If CONFIG_SPARSEMEM is set, the problem is  not noticed because setup_usemap()
> > is always inlined.
> > 
> > Properly annotating setup_usemap() and usemap_size() fixes it.
> 
> Woops, hit the send button too soon.
> 
> setup_usemap() calls alloc_bootmem_node(), causing a whole new
> avalanche of warnings to be fixed up :-(

Something you like me to help with?
I would need a config where the mismatch triggers for one
of the more popular architectures (as in where I have a toolchain).

I could not reproduce it with x86 64bit - not even with -fno-inline-functions

	Sam

  reply	other threads:[~2008-02-17 19:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-17 12:20 Geert Uytterhoeven
2008-02-17 12:31 ` Geert Uytterhoeven
2008-02-17 19:43   ` Sam Ravnborg [this message]
2008-02-17 20:38     ` Geert Uytterhoeven
2008-02-17 22:36       ` Sam Ravnborg
2008-02-18 20:58       ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080217194320.GL14588@uranus.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=akpm@linux-foundation.org \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mel@csn.ul.ie \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®