From: yamamoto@valinux.co.jp (YAMAMOTO Takashi)
To: balbir@linux.vnet.ibm.com
Cc: lizf@cn.fujitsu.com, akpm@linux-foundation.org,
containers@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] memcgroup: fix typo in VM_BUG_ON()
Date: Mon, 18 Feb 2008 15:22:09 +0900 (JST) [thread overview]
Message-ID: <20080218062209.DA59B1E3C58@siro.lan> (raw)
In-Reply-To: Your message of "Mon, 18 Feb 2008 11:44:20 +0530" <47B9223C.9020106@linux.vnet.ibm.com>
> Li Zefan wrote:
> > No need for VM_BUG_ON(pc), since 'pc' is the list entry. This should
> > be VM_BUG_ON(page).
> >
> > Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
> > Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
>
> pc is of type page_cgroup and we use list_for_each_entry_safe_reverse. Not sure
> why we can't bug on pc.
pc is dereferenced before this VM_BUG_ON.
YAMAMOTO Takashi
>
>
>
> --
> Warm Regards,
> Balbir Singh
> Linux Technology Center
> IBM, ISTL
> _______________________________________________
> Containers mailing list
> Containers@lists.linux-foundation.org
> https://lists.linux-foundation.org/mailman/listinfo/containers
next prev parent reply other threads:[~2008-02-18 6:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-18 5:59 Li Zefan
2008-02-18 6:14 ` Balbir Singh
2008-02-18 6:22 ` YAMAMOTO Takashi [this message]
2008-02-18 6:20 ` Balbir Singh
2008-02-18 6:47 ` Li Zefan
2008-02-18 7:01 ` Balbir Singh
2008-02-18 7:14 ` Li Zefan
2008-02-18 7:34 ` [PATCH] memcgroup: remove a useless VM_BUG_ON() Li Zefan
2008-02-18 8:12 ` Balbir Singh
2008-02-18 8:48 ` KAMEZAWA Hiroyuki
2008-02-18 6:39 ` [PATCH 2/3] memcgroup: fix typo in VM_BUG_ON() YAMAMOTO Takashi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080218062209.DA59B1E3C58@siro.lan \
--to=yamamoto@valinux.co.jp \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=containers@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®