From: David Brownell <david-b@pacbell.net>
To: Jan Altenberg <jan.altenberg@linutronix.de>
Cc: tglx@linutronix.de, Greg KH <greg@kroah.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] queue usb USB_CDC_GET_ENCAPSULATED_RESPONSE message
Date: Mon, 18 Feb 2008 18:14:39 -0800 [thread overview]
Message-ID: <200802181814.39402.david-b@pacbell.net> (raw)
In-Reply-To: <1203381890.3923.60.camel@bender.lan>
On Monday 18 February 2008, Jan Altenberg wrote:
> Hi all,
>
> commit 0cf4f2de0a0f4100795f38ef894d4910678c74f8 introduced a bug, which
> prevents sending an USB_CDC_GET_ENCAPSULATED_RESPONSE message. This
> breaks the RNDIS initialization (especially / only Windoze machines
> dislike this behavior...).
>
> Signed-off-by: Benedikt Spranger <b.spranger@linutronix.de>
> Signed-off-by: Jan Altenberg <jan.altenberg@linutronix.de>
Acked-by: David Brownell <dbrownell@users.sourceforge.net>
> ---
> drivers/usb/gadget/ether.c | 1 +
> 1 file changed, 1 insertion(+)
>
> Index: linux-2.6.24/drivers/usb/gadget/ether.c
> ===================================================================
> --- linux-2.6.24.orig/drivers/usb/gadget/ether.c
> +++ linux-2.6.24/drivers/usb/gadget/ether.c
> @@ -1568,6 +1568,7 @@ done_set_intf:
> memcpy(req->buf, buf, n);
> req->complete = rndis_response_complete;
> rndis_free_response(dev->rndis_config, buf);
> + value = n;
> }
> /* else stalls ... spec says to avoid that */
> }
>
>
prev parent reply other threads:[~2008-02-19 2:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-19 0:44 Jan Altenberg
2008-02-19 2:14 ` David Brownell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802181814.39402.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=greg@kroah.com \
--cc=jan.altenberg@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®