From: "Darrick J. Wong" <djwong@us.ibm.com>
To: "Mark M. Hoffman" <mhoffman@lightlink.com>
Cc: Jean Delvare <khali@linux-fr.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
lm-sensors <lm-sensors@lm-sensors.org>
Subject: Re: [lm-sensors] [PATCH] adt7473: New driver for Analog Devices ADT7473 sensor chip
Date: Mon, 18 Feb 2008 13:32:34 -0800 [thread overview]
Message-ID: <20080218213234.GC5784@tree.beaverton.ibm.com> (raw)
In-Reply-To: <20080217200250.GD2916@jupiter.solarsys.private>
On Sun, Feb 17, 2008 at 03:02:50PM -0500, Mark M. Hoffman wrote:
> Documentation/hwmon/adt7473 would be nice.
Ok, I'll generate one.
> That should be const.
Applied.
> > + BUG();
>
> Given ADT7473_PWM_BHVR_SHIFT is 5, this BUG() is obviously impossible.
> But I guess it's not obvious to GCC.
I'll put in a comment to explain that.
> NACK on that comment and associated code: Jean Delvare submitted a
> patch to NVIDIA over two years ago to fix their bug. Apparently some
> distros even carry his patch. So, I don't want to encourage such a
> hack to persist. Please just do the standard check here.
Ok. I wonder if the nouveau people have any intention to
reverse-engineer the i2c controller?
Updated patch to follow soon.
--D
next prev parent reply other threads:[~2008-02-18 21:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-19 3:41 Darrick J. Wong
[not found] ` <20071219154759.7be5025c@hyperion.delvare>
2007-12-19 23:14 ` Darrick J. Wong
2008-02-17 20:02 ` [lm-sensors] " Mark M. Hoffman
2008-02-18 21:32 ` Darrick J. Wong [this message]
2008-02-19 9:52 ` Jean Delvare
2008-02-18 21:33 ` [PATCH v2] " Darrick J. Wong
2008-02-19 3:06 ` [lm-sensors] " Mark M. Hoffman
2008-02-19 9:53 ` [PATCH] " Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080218213234.GC5784@tree.beaverton.ibm.com \
--to=djwong@us.ibm.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=mhoffman@lightlink.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome